Changeset 290133 in webkit

Timestamp:

Feb 18, 2022, 9:32:52 AM (5 years ago)

Author:

Peng Liu

Message:

[iOS][Modern Media Controls] Add an alternative overflow icon
​https://bugs.webkit.org/show_bug.cgi?id=236729

Reviewed by Devin Rousso.

Add a new overflow icon. By default, the media controls will use the
original overflow icon. So this patch does not change the appearance of
the media controls.

• Modules/modern-media-controls/controls/icon-service.js:
• Modules/modern-media-controls/controls/layout-traits.js:

(LayoutTraits.prototype.overflowButtonHasCircle):

• Modules/modern-media-controls/controls/overflow-button.js:

(OverflowButton):

• Modules/modern-media-controls/images/iOS/OverflowCircle.svg: Added.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/modern-media-controls/controls/icon-service.js (modified) (1 diff)
• Modules/modern-media-controls/controls/layout-traits.js (modified) (1 diff)
• Modules/modern-media-controls/controls/overflow-button.js (modified) (1 diff)
• Modules/modern-media-controls/images/iOS/OverflowCircle.svg (added)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-02-18  Peng Liu  <peng.liu6@apple.com>
+
+        [iOS][Modern Media Controls] Add an alternative overflow icon
+        https://bugs.webkit.org/show_bug.cgi?id=236729
+
+        Reviewed by Devin Rousso.
+
+        Add a new overflow icon. By default, the media controls will use the
+        original overflow icon. So this patch does not change the appearance of
+        the media controls.
+
+        * Modules/modern-media-controls/controls/icon-service.js:
+        * Modules/modern-media-controls/controls/layout-traits.js:
+        (LayoutTraits.prototype.overflowButtonHasCircle):
+        * Modules/modern-media-controls/controls/overflow-button.js:
+        (OverflowButton):
+        * Modules/modern-media-controls/images/iOS/OverflowCircle.svg: Added.
+
 2022-02-18  Xabier Rodriguez Calvar  <calvaris@igalia.com>
 

trunk/Source/WebCore/Modules/modern-media-controls/controls/icon-service.js

@@ -36 +36 @@
     InvalidPlacard  : { name: "invalid-placard", type: "png", label: UIString("Invalid") },
     Overflow        : { name: "Overflow", type: "svg", label: UIString("More\u2026") },
+    OverflowCircle  : { name: "OverflowCircle", type: "svg", label: UIString("More\u2026") },
     Pause           : { name: "Pause", type: "svg", label: UIString("Pause") },
     PiPPlacard      : { name: "pip-placard", type: "png", label: UIString("Picture in Picture") },

trunk/Source/WebCore/Modules/modern-media-controls/controls/layout-traits.js

@@ -92 +92 @@
     }
 
+    overflowButtonHasCircle()
+    {
+        return false;
+    }
+
     additionalControlScaleFactor()
     {

trunk/Source/WebCore/Modules/modern-media-controls/controls/overflow-button.js

@@ -31 +31 @@
         super({
             cssClassName: "overflow",
-            iconName: Icons.Overflow,
+            iconName: layoutDelegate?.layoutTraits?.overflowButtonHasCircle() ? Icons.OverflowCircle : Icons.Overflow,
             layoutDelegate,
         });