⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 290662 in webkit


Ignore:
Timestamp:
Mar 1, 2022, 11:29:54 AM (5 years ago)
Author:
graouts@webkit.org
Message:

[web-animations] ::placeholder should not be a valid pseudo-element for a KeyframeEffect target
​https://bugs.webkit.org/show_bug.cgi?id=237334

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

  • web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt:
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/target-expected.txt:

Source/WebCore:

  • animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::setPseudoElement):

Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r290655 r290662  
     12022-03-01  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] ::placeholder should not be a valid pseudo-element for a KeyframeEffect target
     4        https://bugs.webkit.org/show_bug.cgi?id=237334
     5
     6        Reviewed by Dean Jackson.
     7
     8        * web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt:
     9        * web-platform-tests/web-animations/interfaces/KeyframeEffect/target-expected.txt:
     10
    1112022-03-01  Antoine Quint  <graouts@webkit.org>
    212

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt

    r290655 r290662  
    150150PASS animate() with a non-null invalid pseudoElement ':abc' throws a SyntaxError
    151151PASS animate() with a non-null invalid pseudoElement '::abc' throws a SyntaxError
    152 FAIL animate() with a non-null invalid pseudoElement '::placeholder' throws a SyntaxError assert_throws_dom: function "() => {
    153       div.animate(null, {pseudoElement: pseudo});
    154     }" did not throw
     152PASS animate() with a non-null invalid pseudoElement '::placeholder' throws a SyntaxError
    155153

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/target-expected.txt

    r267649 r290662  
    2323PASS Changing pseudoElement to a non-null invalid pseudo-selector ':abc' throws a SyntaxError
    2424PASS Changing pseudoElement to a non-null invalid pseudo-selector '::abc' throws a SyntaxError
    25 FAIL Changing pseudoElement to a non-null invalid pseudo-selector '::placeholder' throws a SyntaxError assert_throws_dom: function "() => effect.pseudoElement = pseudo" did not throw
     25PASS Changing pseudoElement to a non-null invalid pseudo-selector '::placeholder' throws a SyntaxError
    2626

  • trunk/Source/WebCore/ChangeLog

    r290656 r290662  
     12022-03-01  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] ::placeholder should not be a valid pseudo-element for a KeyframeEffect target
     4        https://bugs.webkit.org/show_bug.cgi?id=237334
     5
     6        Reviewed by Dean Jackson.
     7
     8        * animation/KeyframeEffect.cpp:
     9        (WebCore::KeyframeEffect::setPseudoElement):
     10
    1112022-03-01  Alex Christensen  <achristensen@webkit.org>
    212

  • trunk/Source/WebCore/animation/KeyframeEffect.cpp

    r290584 r290662  
    11841184            return Exception { SyntaxError };
    11851185        auto pseudoType = CSSSelector::parsePseudoElementType(pseudoElement.substring(isLegacy ? 1 : 2));
    1186         if (pseudoType == CSSSelector::PseudoElementUnknown)
     1186        if (pseudoType == CSSSelector::PseudoElementUnknown || pseudoType == CSSSelector::PseudoElementWebKitCustom)
    11871187            return Exception { SyntaxError };
    11881188        pseudoId = CSSSelector::pseudoId(pseudoType);
Note: See TracChangeset for help on using the changeset viewer.