Context Navigation

← Previous Changeset
Next Changeset →

Changeset 290664 in webkit

Timestamp:

Mar 1, 2022, 11:38:24 AM (5 years ago)

Author:

ysuzuki@apple.com

Message:

Fix Speedometer's setTimeout throttling issue
https://bugs.webkit.org/show_bug.cgi?id=237303
rdar://89444976

Reviewed by Geoffrey Garen.

Speedometer is driving each test via setTimeout. Because we are using setTimeout to
measure async time in each subtest of Speedometer, our measurement included 4ms
throttle introduced due to nested setTimeout. This is happening in the test
harness (not test itself), and the intention of this test harness is not measuring
the throttle time. In this patch, we fix this nesting level propagation by inserting
window.requestAnimationFrame for each test run and BenchmarkRunner.prototype.waitForElement
so that we can reset nesting level count of setTimeout, which prevents the rendering
engine to insert 4ms throttle.

Since this affects on the score of async measurement, we bump the version number from 2.0 to 2.1

Speedometer/InteractiveRunner.html:
Speedometer/index.html:
Speedometer/resources/benchmark-runner.js:

(resolveIfReady):
(BenchmarkRunner.prototype.waitForElement):
(BenchmarkRunner.prototype._runTest):

Speedometer/resources/todomvc/architecture-examples/angular/README.md:
Speedometer/resources/todomvc/architecture-examples/angularjs/readme.md:
Speedometer/resources/todomvc/architecture-examples/backbone/readme.md:
Speedometer/resources/todomvc/architecture-examples/emberjs/README.md:
Speedometer/resources/todomvc/architecture-examples/preact/README.md:
Speedometer/resources/todomvc/architecture-examples/react-redux/README.md:
Speedometer/resources/todomvc/architecture-examples/react/README.md:
Speedometer/resources/todomvc/architecture-examples/vuejs-cli/README.md:
Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/README.md:
Speedometer/resources/todomvc/vanilla-examples/es2015/README.md:
Speedometer/resources/todomvc/vanilla-examples/vanillajs/readme.md:

Location:

trunk/PerformanceTests

Files:

: 15 edited

ChangeLog (modified) (1 diff)
Speedometer/InteractiveRunner.html (modified) (1 diff)
Speedometer/index.html (modified) (2 diffs)
Speedometer/resources/benchmark-runner.js (modified) (2 diffs)
Speedometer/resources/todomvc/architecture-examples/angular/README.md (modified) (1 diff)
Speedometer/resources/todomvc/architecture-examples/angularjs/readme.md (modified) (1 diff)
Speedometer/resources/todomvc/architecture-examples/backbone/readme.md (modified) (1 diff)
Speedometer/resources/todomvc/architecture-examples/emberjs/README.md (modified) (1 diff)
Speedometer/resources/todomvc/architecture-examples/preact/README.md (modified) (1 diff)
Speedometer/resources/todomvc/architecture-examples/react-redux/README.md (modified) (1 diff)
Speedometer/resources/todomvc/architecture-examples/react/README.md (modified) (1 diff)
Speedometer/resources/todomvc/architecture-examples/vuejs-cli/README.md (modified) (1 diff)
Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/README.md (modified) (1 diff)
Speedometer/resources/todomvc/vanilla-examples/es2015/README.md (modified) (1 diff)
Speedometer/resources/todomvc/vanilla-examples/vanillajs/readme.md (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/PerformanceTests/ChangeLog

-              r290179
+              r290664
+-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
+        Fix Speedometer's setTimeout throttling issue
+        https://bugs.webkit.org/show_bug.cgi?id=237303
+        rdar://89444976
+        Reviewed by Geoffrey Garen.
+        Speedometer is driving each test via setTimeout. Because we are using setTimeout to
+        measure async time in each subtest of Speedometer, our measurement included 4ms
+        throttle introduced due to nested setTimeout. This is happening in the test
+        harness (not test itself), and the intention of this test harness is not measuring
+        the throttle time. In this patch, we fix this nesting level propagation by inserting
+        window.requestAnimationFrame for each test run and BenchmarkRunner.prototype.waitForElement
+        so that we can reset nesting level count of setTimeout, which prevents the rendering
+        engine to insert 4ms throttle.
+        Since this affects on the score of async measurement, we bump the version number from 2.0 to 2.1
+        * Speedometer/InteractiveRunner.html:
+        * Speedometer/index.html:
+        * Speedometer/resources/benchmark-runner.js:
+        (resolveIfReady):
+        (BenchmarkRunner.prototype.waitForElement):
+        (BenchmarkRunner.prototype._runTest):
+        * Speedometer/resources/todomvc/architecture-examples/angular/README.md:
+        * Speedometer/resources/todomvc/architecture-examples/angularjs/readme.md:
+        * Speedometer/resources/todomvc/architecture-examples/backbone/readme.md:
+        * Speedometer/resources/todomvc/architecture-examples/emberjs/README.md:
+        * Speedometer/resources/todomvc/architecture-examples/preact/README.md:
+        * Speedometer/resources/todomvc/architecture-examples/react-redux/README.md:
+        * Speedometer/resources/todomvc/architecture-examples/react/README.md:
+        * Speedometer/resources/todomvc/architecture-examples/vuejs-cli/README.md:
+        * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/README.md:
+        * Speedometer/resources/todomvc/vanilla-examples/es2015/README.md:
+        * Speedometer/resources/todomvc/vanilla-examples/vanillajs/readme.md:
 -02-18  Robert Jenner  <Jenner@apple.com>

trunk/PerformanceTests/Speedometer/InteractiveRunner.html

r222466	r290664
2	2	<html>
3	3	<head>
4		<title>Speedometer 2.0 Interactive Runner</title>
	4	<title>Speedometer 2.1 Interactive Runner</title>
5	5	<script src="resources/benchmark-runner.js" defer></script>
6	6	<script src="resources/tests.js" defer></script>

trunk/PerformanceTests/Speedometer/index.html

-              r226694
+              r290664
 <head>
     <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
     <title>Speedometer 2.0</title>
+    <title>Speedometer 2.1</title>
     <link rel="stylesheet" href="resources/main.css">
     <script src="resources/main.js" defer></script>
 …
     <section id="about">
         <h1>About Speedometer 2.0</h1>
+        <h1>About Speedometer 2.1</h1>
         <p>Speedometer tests a browser's Web app responsiveness by timing simulated user interactions.</p>

trunk/PerformanceTests/Speedometer/resources/benchmark-runner.js

-              r221659
+              r290664
     function resolveIfReady() {
         var element = contentDocument.querySelector(selector);
+        if (element)
+            return promise.resolve(element);
+        if (element) {
+            window.requestAnimationFrame(function () {
+                return promise.resolve(element);
+            });
+            return;
+        }
         setTimeout(resolveIfReady, 50);
+    }
 …
         self._frame.contentWindow._unusedHeightValue = height; // Prevent dead code elimination.
         self._writeMark(suite.name + '.' + test.name + '-async-end');
+        callback(syncTime, endTime - startTime, height);
+        window.requestAnimationFrame(function () {
+            callback(syncTime, endTime - startTime, height);
+        });
     }, 0);
+}

trunk/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angular/README.md

r219993	r290664
1		# Speedometer 2.0: Angular 4 TodoMVC example
	1	# Speedometer 2.1: Angular 4 TodoMVC example
2	2
3	3	## Test locally

trunk/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angularjs/readme.md

r220801	r290664
1		# Speedometer 2.0: Angular 1.6.5 TodoMVC example
	1	# Speedometer 2.1: Angular 1.6.5 TodoMVC example
2	2
3	3	## Test locally

trunk/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/backbone/readme.md

r220800	r290664
1		# Speedometer 2.0: Backbone.js TodoMVC example
	1	# Speedometer 2.1: Backbone.js TodoMVC example
2	2
3	3	## Test locally

trunk/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/emberjs/README.md

r221206	r290664
1		# Speedometer 2.0: Ember.js TodoMVC example
	1	# Speedometer 2.1: Ember.js TodoMVC example
2	2
3	3	## Test locally

trunk/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/preact/README.md

r221121	r290664
1		# Speedometer 2.0: Preact TodoMVC example
	1	# Speedometer 2.1: Preact TodoMVC example
2	2
3	3	## Test locally

trunk/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/react-redux/README.md

r220899	r290664
1		# Speedometer 2.0: React Redux TodoMVC example
	1	# Speedometer 2.1: React Redux TodoMVC example
2	2
3	3	## Test locally

trunk/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/react/README.md

r221104	r290664
1		# Speedometer 2.0: React TodoMVC example
	1	# Speedometer 2.1: React TodoMVC example
2	2
3	3	## Test locally

trunk/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/vuejs-cli/README.md

r220900	r290664
1		# Speedometer 2.0: Vue.js TodoMVC example
	1	# Speedometer 2.1: Vue.js TodoMVC example
2	2
3	3	## Test locally

trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/README.md

r219903	r290664
1		# Speedometer 2.0: ES2015 + Babel + Webpack TodoMVC example
	1	# Speedometer 2.1: ES2015 + Babel + Webpack TodoMVC example
2	2
3	3	## Test locally

trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/es2015/README.md

r220043	r290664
1		# Speedometer 2.0: ES2015 TodoMVC example
	1	# Speedometer 2.1: ES2015 TodoMVC example
2	2
3	3	## Test locally

trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/readme.md

r219251	r290664
1		# Speedometer 2.0: Vanilla JavaScript TodoMVC example
	1	# Speedometer 2.1: Vanilla JavaScript TodoMVC example
2	2
3	3	## Test locally

Note: See TracChangeset for help on using the changeset viewer.

Context Navigation

Changeset 290664 in webkit

Legend:

Download in other formats: