Changeset 290892 in webkit

Timestamp:

Mar 7, 2022, 9:29:22 AM (5 years ago)

Author:

Peng Liu

Message:

Small cleanups of media code
​https://bugs.webkit.org/show_bug.cgi?id=237496

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

No new tests. No behavior change.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updatePlayState): schedulePlaybackControlsManagerUpdate() is
called in both branches.

Source/WebKit:

• WebProcess/cocoa/PlaybackSessionManager.h: protected is not needed here.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLMediaElement.cpp (modified) (2 diffs)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/WebProcess/cocoa/PlaybackSessionManager.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-03-07  Peng Liu  <peng.liu6@apple.com>
+
+        Small cleanups of media code
+        https://bugs.webkit.org/show_bug.cgi?id=237496
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        No new tests. No behavior change.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::updatePlayState): `schedulePlaybackControlsManagerUpdate()` is
+        called in both branches.
+
 2022-03-07  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -5623 +5623 @@
     }
 
+    schedulePlaybackControlsManagerUpdate();
     if (shouldBePlaying) {
-        schedulePlaybackControlsManagerUpdate();
-
         invalidateCachedTime();
 
@@ -5650 +5649 @@
         setPlaying(true);
     } else {
-        schedulePlaybackControlsManagerUpdate();
-
         if (!playerPaused)
             pausePlayer();

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-03-07  Peng Liu  <peng.liu6@apple.com>
+
+        Small cleanups of media code
+        https://bugs.webkit.org/show_bug.cgi?id=237496
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        * WebProcess/cocoa/PlaybackSessionManager.h: `protected` is not needed here.
+
 2022-03-07  Adrian Perez de Castro  <aperez@igalia.com>
 

trunk/Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h

@@ -111 +111 @@
     WebCore::HTMLMediaElement* currentPlaybackControlsElement() const;
 
-protected:
+private:
     friend class PlaybackSessionInterfaceContext;
     friend class VideoFullscreenManager;