⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 290909 in webkit


Ignore:
Timestamp:
Mar 7, 2022, 2:08:34 PM (5 years ago)
Author:
Russell Epstein
Message:

Cherry-pick r287986. rdar://problem/87489048

Fix a few Objective-C object leaks due to early returns in init
​https://bugs.webkit.org/show_bug.cgi?id=235162
<rdar://problem/87489048>

Reviewed by Wenson Hsieh.

Source/JavaScriptCore:

  • API/JSValue.mm: (-[JSValue initWithValue:inContext:]):

Source/WebCore:

  • platform/ios/WebAVPlayerController.mm: (-[WebAVPlayerController init]):

Source/WebKit:

  • UIProcess/ios/WKHoverPlatter.mm: (-[WKHoverPlatter initWithView:delegate:]):

Source/WebKitLegacy/mac:

  • Storage/WebDatabaseQuotaManager.mm: (WebCore::if):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:
branches/safari-613-branch/Source
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • branches/safari-613-branch/Source/JavaScriptCore/API/JSValue.mm

    r277920 r290909  
    11091109- (JSValue *)initWithValue:(JSValueRef)value inContext:(JSContext *)context
    11101110{
    1111     if (!value || !context)
     1111    if (!value || !context) {
     1112        [self release];
    11121113        return nil;
     1114    }
    11131115
    11141116    self = [super init];

  • branches/safari-613-branch/Source/JavaScriptCore/ChangeLog

    r290789 r290909  
     12022-03-07  Russell Epstein  <repstein@apple.com>
     2
     3        Cherry-pick r287986. rdar://problem/87489048
     4
     5    Fix a few Objective-C object leaks due to early returns in `init`
     6    https://bugs.webkit.org/show_bug.cgi?id=235162
     7    <rdar://problem/87489048>
     8   
     9    Reviewed by Wenson Hsieh.
     10   
     11    Source/JavaScriptCore:
     12   
     13    * API/JSValue.mm:
     14    (-[JSValue initWithValue:inContext:]):
     15   
     16    Source/WebCore:
     17   
     18    * platform/ios/WebAVPlayerController.mm:
     19    (-[WebAVPlayerController init]):
     20   
     21    Source/WebKit:
     22   
     23    * UIProcess/ios/WKHoverPlatter.mm:
     24    (-[WKHoverPlatter initWithView:delegate:]):
     25   
     26    Source/WebKitLegacy/mac:
     27   
     28    * Storage/WebDatabaseQuotaManager.mm:
     29    (WebCore::if):
     30   
     31   
     32    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     33
     34    2022-01-13  Tim Horton  <timothy_horton@apple.com>
     35
     36            Fix a few Objective-C object leaks due to early returns in `init`
     37            https://bugs.webkit.org/show_bug.cgi?id=235162
     38            <rdar://problem/87489048>
     39
     40            Reviewed by Wenson Hsieh.
     41
     42            * API/JSValue.mm:
     43            (-[JSValue initWithValue:inContext:]):
     44
    1452022-03-03  Russell Epstein  <repstein@apple.com>
    246

  • branches/safari-613-branch/Source/WebCore/ChangeLog

    r290701 r290909  
     12022-03-07  Russell Epstein  <repstein@apple.com>
     2
     3        Cherry-pick r287986. rdar://problem/87489048
     4
     5    Fix a few Objective-C object leaks due to early returns in `init`
     6    https://bugs.webkit.org/show_bug.cgi?id=235162
     7    <rdar://problem/87489048>
     8   
     9    Reviewed by Wenson Hsieh.
     10   
     11    Source/JavaScriptCore:
     12   
     13    * API/JSValue.mm:
     14    (-[JSValue initWithValue:inContext:]):
     15   
     16    Source/WebCore:
     17   
     18    * platform/ios/WebAVPlayerController.mm:
     19    (-[WebAVPlayerController init]):
     20   
     21    Source/WebKit:
     22   
     23    * UIProcess/ios/WKHoverPlatter.mm:
     24    (-[WKHoverPlatter initWithView:delegate:]):
     25   
     26    Source/WebKitLegacy/mac:
     27   
     28    * Storage/WebDatabaseQuotaManager.mm:
     29    (WebCore::if):
     30   
     31   
     32    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     33
     34    2022-01-13  Tim Horton  <timothy_horton@apple.com>
     35
     36            Fix a few Objective-C object leaks due to early returns in `init`
     37            https://bugs.webkit.org/show_bug.cgi?id=235162
     38            <rdar://problem/87489048>
     39
     40            Reviewed by Wenson Hsieh.
     41
     42            * platform/ios/WebAVPlayerController.mm:
     43            (-[WebAVPlayerController init]):
     44
    1452022-03-01  Russell Epstein  <repstein@apple.com>
    246

  • branches/safari-613-branch/Source/WebCore/platform/ios/WebAVPlayerController.mm

    r284743 r290909  
    6767- (instancetype)init
    6868{
    69     if (!getAVPlayerControllerClass())
     69    if (!getAVPlayerControllerClass()) {
     70        [self release];
    7071        return nil;
     72    }
    7173
    7274    if (!(self = [super init]))

  • branches/safari-613-branch/Source/WebKit/ChangeLog

    r290708 r290909  
     12022-03-07  Russell Epstein  <repstein@apple.com>
     2
     3        Cherry-pick r287986. rdar://problem/87489048
     4
     5    Fix a few Objective-C object leaks due to early returns in `init`
     6    https://bugs.webkit.org/show_bug.cgi?id=235162
     7    <rdar://problem/87489048>
     8   
     9    Reviewed by Wenson Hsieh.
     10   
     11    Source/JavaScriptCore:
     12   
     13    * API/JSValue.mm:
     14    (-[JSValue initWithValue:inContext:]):
     15   
     16    Source/WebCore:
     17   
     18    * platform/ios/WebAVPlayerController.mm:
     19    (-[WebAVPlayerController init]):
     20   
     21    Source/WebKit:
     22   
     23    * UIProcess/ios/WKHoverPlatter.mm:
     24    (-[WKHoverPlatter initWithView:delegate:]):
     25   
     26    Source/WebKitLegacy/mac:
     27   
     28    * Storage/WebDatabaseQuotaManager.mm:
     29    (WebCore::if):
     30   
     31   
     32    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     33
     34    2022-01-13  Tim Horton  <timothy_horton@apple.com>
     35
     36            Fix a few Objective-C object leaks due to early returns in `init`
     37            https://bugs.webkit.org/show_bug.cgi?id=235162
     38            <rdar://problem/87489048>
     39
     40            Reviewed by Wenson Hsieh.
     41
     42            * UIProcess/ios/WKHoverPlatter.mm:
     43            (-[WKHoverPlatter initWithView:delegate:]):
     44
    1452022-03-01  Russell Epstein  <repstein@apple.com>
    246

  • branches/safari-613-branch/Source/WebKit/UIProcess/ios/WKHoverPlatter.mm

    r284453 r290909  
    9494{
    9595    auto parameters = WKHoverPlatterDomain.rootSettings;
    96     if (!parameters.platterEnabledForMouse && !parameters.platterEnabledForHover)
     96    if (!parameters.platterEnabledForMouse && !parameters.platterEnabledForHover) {
     97        [self release];
    9798        return nil;
     99    }
    98100
    99101    self = [super init];

  • branches/safari-613-branch/Source/WebKitLegacy/mac/ChangeLog

    r290694 r290909  
     12022-03-07  Russell Epstein  <repstein@apple.com>
     2
     3        Cherry-pick r287986. rdar://problem/87489048
     4
     5    Fix a few Objective-C object leaks due to early returns in `init`
     6    https://bugs.webkit.org/show_bug.cgi?id=235162
     7    <rdar://problem/87489048>
     8   
     9    Reviewed by Wenson Hsieh.
     10   
     11    Source/JavaScriptCore:
     12   
     13    * API/JSValue.mm:
     14    (-[JSValue initWithValue:inContext:]):
     15   
     16    Source/WebCore:
     17   
     18    * platform/ios/WebAVPlayerController.mm:
     19    (-[WebAVPlayerController init]):
     20   
     21    Source/WebKit:
     22   
     23    * UIProcess/ios/WKHoverPlatter.mm:
     24    (-[WKHoverPlatter initWithView:delegate:]):
     25   
     26    Source/WebKitLegacy/mac:
     27   
     28    * Storage/WebDatabaseQuotaManager.mm:
     29    (WebCore::if):
     30   
     31   
     32    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     33
     34    2022-01-13  Tim Horton  <timothy_horton@apple.com>
     35
     36            Fix a few Objective-C object leaks due to early returns in `init`
     37            https://bugs.webkit.org/show_bug.cgi?id=235162
     38            <rdar://problem/87489048>
     39
     40            Reviewed by Wenson Hsieh.
     41
     42            * Storage/WebDatabaseQuotaManager.mm:
     43            (WebCore::if):
     44
    1452022-03-01  Russell Epstein  <repstein@apple.com>
    246

  • branches/safari-613-branch/Source/WebKitLegacy/mac/Storage/WebDatabaseQuotaManager.mm

    r229979 r290909  
    3636- (id)initWithOrigin:(WebSecurityOrigin *)origin
    3737{
    38     if (!origin)
     38    if (!origin) {
     39        [self release];
    3940        return nil;
     41    }
    4042
    4143    self = [super init];
Note: See TracChangeset for help on using the changeset viewer.