Changeset 290910 in webkit

Timestamp:

Mar 7, 2022, 2:08:37 PM (5 years ago)

Author:

Russell Epstein

Message:

Cherry-pick r288237. rdar://problem/87275093

WebKit::AuthenticatorPresenterCoordinator() constructor falls through ASSERT_NOT_REACHED()
​https://bugs.webkit.org/show_bug.cgi?id=234991
<rdar://problem/87275093>

Reviewed by Darin Adler.

Drop unnecessary default: case in the switch statement since it handles all enum values already.

• UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm: (WebKit::AuthenticatorPresenterCoordinator::AuthenticatorPresenterCoordinator):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@288237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-613-branch/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm (modified) (1 diff)

branches/safari-613-branch/Source/WebKit/ChangeLog

@@ +1 @@
+2022-03-07  Russell Epstein  <repstein@apple.com>
+
+        Cherry-pick r288237. rdar://problem/87275093
+
+    WebKit::AuthenticatorPresenterCoordinator() constructor falls through ASSERT_NOT_REACHED()
+    https://bugs.webkit.org/show_bug.cgi?id=234991
+    <rdar://problem/87275093>
+    
+    Reviewed by Darin Adler.
+    
+    Drop unnecessary default: case in the switch statement since it handles all enum values already.
+    
+    * UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:
+    (WebKit::AuthenticatorPresenterCoordinator::AuthenticatorPresenterCoordinator):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2022-01-19  Chris Dumez  <cdumez@apple.com>
+
+            WebKit::AuthenticatorPresenterCoordinator() constructor falls through ASSERT_NOT_REACHED()
+            https://bugs.webkit.org/show_bug.cgi?id=234991
+            <rdar://problem/87275093>
+
+            Reviewed by Darin Adler.
+
+            Drop unnecessary default: case in the switch statement since it handles all enum values already.
+
+            * UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:
+            (WebKit::AuthenticatorPresenterCoordinator::AuthenticatorPresenterCoordinator):
+
 2022-03-07  Russell Epstein  <repstein@apple.com>
 

branches/safari-613-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm

@@ -61 +61 @@
             [m_context addLoginChoice:adoptNS([allocASCSecurityKeyPublicKeyCredentialLoginChoiceInstance() initAssertionPlaceholderChoice]).get()];
         break;
-    default:
-        ASSERT_NOT_REACHED();
     }