Changeset 29119 in webkit

Timestamp:

Jan 3, 2008, 3:04:04 AM (17 years ago)

Author:

alp@webkit.org

Message:

2008-01-03 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

Fix HTTP POST-based logins to sites like Facebook, GMail by ensuring
that the two POST methods don't conflict.

• platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/curl/ResourceHandleManager.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-01-03  Luca Bruno  <lethalman88@gmail.com>
+
+        Reviewed by Alp Toker.
+
+        Fix HTTP POST-based logins to sites like Facebook, GMail by ensuring
+        that the two POST methods don't conflict.
+
+        * platform/network/curl/ResourceHandleManager.cpp:
+        (WebCore::ResourceHandleManager::setupPOST):
+
 2008-01-02  Darin Adler  <darin@apple.com>
 

trunk/WebCore/platform/network/curl/ResourceHandleManager.cpp

@@ -298 +298 @@
     ResourceHandleInternal* d = job->getInternal();
 
-    curl_easy_setopt(d->m_handle, CURLOPT_POST, TRUE);
-
     job->request().httpBody()->flatten(d->m_postBytes);
     if (d->m_postBytes.size() != 0) {
+        curl_easy_setopt(d->m_handle, CURLOPT_POST, TRUE);
         curl_easy_setopt(d->m_handle, CURLOPT_POSTFIELDSIZE, d->m_postBytes.size());
         curl_easy_setopt(d->m_handle, CURLOPT_POSTFIELDS, d->m_postBytes.data());
@@ -331 +330 @@
     }
 
-    curl_easy_setopt(d->m_handle, CURLOPT_HTTPPOST, post);
+    if (post)
+      curl_easy_setopt(d->m_handle, CURLOPT_HTTPPOST, post);
 }