Changeset 291724 in webkit

Timestamp:

Mar 22, 2022, 4:37:42 PM (4 years ago)

Author:

Tyler Wilcock

Message:

Expose the AX tree of PDFs loaded via iframes on the Mac
​https://bugs.webkit.org/show_bug.cgi?id=238168

Reviewed by Chris Fleizach.

Source/WebKit:

Given this markup:

<iframe src="/path/to/paystub.pdf">

An accessibility tree is built for paystub.pdf, but we don't expose it
to AX clients, making the PDF entirely inaccessible.

This happens because we were setting the AX parent to be the webpage
for full-frame PDF plugins (which an iframe with this markup is).
This behavior is correct only for main-frame (i.e. not iframe)
full-frame plugins, so this patch adds an extra condition to that logic.

Test: accessibility/mac/iframe-pdf.html

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::PDFPlugin):

LayoutTests:

• accessibility/mac/iframe-pdf-expected.txt: Added.
• accessibility/mac/iframe-pdf.html: Added.
• platform/mac-wk1/TestExpectations:

Skip new test as it always times out in WK1 (similar to
accessibility/mac/basic-embed-pdf-accessibility.html)

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/mac/iframe-pdf-expected.txt (added)
• LayoutTests/accessibility/mac/iframe-pdf.html (added)
• LayoutTests/platform/mac-wk1/TestExpectations (modified) (1 diff)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2022-03-22  Tyler Wilcock  <tyler_w@apple.com>
+
+        Expose the AX tree of PDFs loaded via iframes on the Mac
+        https://bugs.webkit.org/show_bug.cgi?id=238168
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/mac/iframe-pdf-expected.txt: Added.
+        * accessibility/mac/iframe-pdf.html: Added.
+        * platform/mac-wk1/TestExpectations:
+        Skip new test as it always times out in WK1 (similar to
+        accessibility/mac/basic-embed-pdf-accessibility.html)
+
 2022-03-22  Robert Jenner  <Jenner@apple.com>
 

trunk/LayoutTests/platform/mac-wk1/TestExpectations

@@ -872 +872 @@
 # Skip because the embedded plugin never resolves in WK1, resulting in a timeout.
 accessibility/mac/basic-embed-pdf-accessibility.html [ Skip ]
+accessibility/mac/iframe-pdf.html [ Skip ]
 
 # rdar://problem/26478296

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-03-22  Tyler Wilcock  <tyler_w@apple.com>
+
+        Expose the AX tree of PDFs loaded via iframes on the Mac
+        https://bugs.webkit.org/show_bug.cgi?id=238168
+
+        Reviewed by Chris Fleizach.
+
+        Given this markup:
+
+        <iframe src="/path/to/paystub.pdf">
+
+        An accessibility tree is built for paystub.pdf, but we don't expose it
+        to AX clients, making the PDF entirely inaccessible.
+
+        This happens because we were setting the AX parent to be the webpage
+        for full-frame PDF plugins (which an iframe with this markup is).
+        This behavior is correct only for main-frame (i.e. not iframe)
+        full-frame plugins, so this patch adds an extra condition to that logic.
+
+        Test: accessibility/mac/iframe-pdf.html
+
+        * WebProcess/Plugins/PDF/PDFPlugin.mm:
+        (WebKit::PDFPlugin::PDFPlugin):
+
 2022-03-22  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm

@@ -674 +674 @@
     m_accessibilityObject = adoptNS([[WKPDFPluginAccessibilityObject alloc] initWithPDFPlugin:this andElement:pluginElement]);
     [m_accessibilityObject setPdfLayerController:m_pdfLayerController.get()];
-    if (isFullFrame)
+    if (isFullFrame && frame.isMainFrame())
         [m_accessibilityObject setParent:frame.page()->accessibilityRemoteObject()];
-    // If the plugin is not full-frame, we'll need to set the parent later after the AXObjectCache for the document has been initialized.
+    // If this is not a main-frame (e.g. it originated from an iframe) full-frame plugin, we'll need to set the parent later after the AXObjectCache has been initialized.
 
     [m_containerLayer addSublayer:m_contentLayer.get()];