Changeset 291731 in webkit

Timestamp:

Mar 22, 2022, 6:27:54 PM (5 years ago)

Author:

Chris Dumez

Message:

Use ASCIILiteral in a few more places where it is useful
​https://bugs.webkit.org/show_bug.cgi?id=238235

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• runtime/FunctionExecutable.cpp:

(JSC::FunctionExecutable::toStringSlow):

Source/WebCore:

• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::setValueCommon):

• platform/animation/TimingFunction.cpp:

(WebCore::TimingFunction::cssText const):

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/runtime/FunctionExecutable.cpp (modified) (3 diffs)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLTextAreaElement.cpp (modified) (1 diff)
• WebCore/platform/animation/TimingFunction.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2022-03-22  Chris Dumez  <cdumez@apple.com>
+
+        Use ASCIILiteral in a few more places where it is useful
+        https://bugs.webkit.org/show_bug.cgi?id=238235
+
+        Reviewed by Geoffrey Garen.
+
+        * runtime/FunctionExecutable.cpp:
+        (JSC::FunctionExecutable::toStringSlow):
+
 2022-03-21  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/runtime/FunctionExecutable.cpp

@@ -146 +146 @@
     case SourceParseMode::GeneratorWrapperFunctionMode:
     case SourceParseMode::GeneratorWrapperMethodMode:
-        functionHeader = "function* ";
+        functionHeader = "function* "_s;
         break;
 
@@ -160 +160 @@
     case SourceParseMode::AsyncFunctionBodyMode:
     case SourceParseMode::AsyncArrowFunctionBodyMode:
-        functionHeader = "function ";
+        functionHeader = "function "_s;
         break;
 
@@ -170 +170 @@
     case SourceParseMode::AsyncFunctionMode:
     case SourceParseMode::AsyncMethodMode:
-        functionHeader = "async function ";
+        functionHeader = "async function "_s;
         break;
 
     case SourceParseMode::AsyncArrowFunctionMode:
-        functionHeader = "async ";
+        functionHeader = "async "_s;
         break;
 
     case SourceParseMode::AsyncGeneratorWrapperFunctionMode:
     case SourceParseMode::AsyncGeneratorWrapperMethodMode:
-        functionHeader = "async function* ";
+        functionHeader = "async function* "_s;
         break;
     }

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-03-22  Chris Dumez  <cdumez@apple.com>
+
+        Use ASCIILiteral in a few more places where it is useful
+        https://bugs.webkit.org/show_bug.cgi?id=238235
+
+        Reviewed by Geoffrey Garen.
+
+        * html/HTMLTextAreaElement.cpp:
+        (WebCore::HTMLTextAreaElement::setValueCommon):
+        * platform/animation/TimingFunction.cpp:
+        (WebCore::TimingFunction::cssText const):
+
 2022-03-22  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/html/HTMLTextAreaElement.cpp

@@ -396 +396 @@
     // We normalize line endings coming from JavaScript here.
     String normalizedValue = newValue.isNull() ? emptyString() : newValue;
-    normalizedValue.replace("\r\n", "\n");
+    normalizedValue.replace("\r\n"_s, "\n"_s);
     normalizedValue.replace('\r', '\n');
 

trunk/Source/WebCore/platform/animation/TimingFunction.cpp

@@ -199 +199 @@
         auto& function = downcast<CubicBezierTimingFunction>(*this);
         if (function.x1() == 0.25 && function.y1() == 0.1 && function.x2() == 0.25 && function.y2() == 1.0)
-            return "ease";
+            return "ease"_s;
         if (function.x1() == 0.42 && !function.y1() && function.x2() == 1.0 && function.y2() == 1.0)
-            return "ease-in";
+            return "ease-in"_s;
         if (!function.x1() && !function.y1() && function.x2() == 0.58 && function.y2() == 1.0)
-            return "ease-out";
+            return "ease-out"_s;
         if (function.x1() == 0.42 && !function.y1() && function.x2() == 0.58 && function.y2() == 1.0)
-            return "ease-in-out";
+            return "ease-in-out"_s;
         return makeString("cubic-bezier(", function.x1(), ", ", function.y1(), ", ", function.x2(), ", ", function.y2(), ')');
     }