Changeset 291732 in webkit

Timestamp:

Mar 22, 2022, 6:39:19 PM (5 years ago)

Author:

sihui_liu@apple.com

Message:

REGRESSION (248499@main): [iOS] ASSERTION FAILED: Completion handler should always be called under WebKit::NetworkProcess::prepareToSuspend()
​https://bugs.webkit.org/show_bug.cgi?id=238234
<rdar://problem/90665237>

Reviewed by Chris Dumez.

Invoke completion handler on early return.

• NetworkProcess/storage/NetworkStorageManager.cpp:

(WebKit::NetworkStorageManager::suspend):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/storage/NetworkStorageManager.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-03-22  Sihui Liu  <sihui_liu@apple.com>
+
+        REGRESSION (248499@main): [iOS] ASSERTION FAILED: Completion handler should always be called under WebKit::NetworkProcess::prepareToSuspend()
+        https://bugs.webkit.org/show_bug.cgi?id=238234
+        <rdar://problem/90665237>
+
+        Reviewed by Chris Dumez.
+
+        Invoke completion handler on early return.
+
+        * NetworkProcess/storage/NetworkStorageManager.cpp:
+        (WebKit::NetworkStorageManager::suspend):
+
 2022-03-22  Megan Gardner  <megan_gardner@apple.com>
 

trunk/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp

@@ -647 +647 @@
 
     if (m_sessionID.isEphemeral())
-        return;
+        return completionHandler();
 
     m_queue->suspend([this, protectedThis = Ref { *this }] {