Changeset 291734 in webkit

Timestamp:

Mar 22, 2022, 9:25:54 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Add a few more WEBCORE_EXPORT macros
​https://bugs.webkit.org/show_bug.cgi?id=238214

Patch by Alex Christensen <​achristensen@webkit.org> on 2022-03-22
Reviewed by Eric Carlson.

These are needed to successfully link when building with -fsanitize=fuzzer,address

• dom/Document.h:
• html/HTMLCollection.h:
• html/HTMLOptionsCollection.h:
• platform/Pasteboard.h:
• platform/mediastream/mac/CoreAudioCaptureSource.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.h (modified) (1 diff)
• html/HTMLCollection.h (modified) (3 diffs)
• html/HTMLOptionsCollection.h (modified) (1 diff)
• platform/Pasteboard.h (modified) (1 diff)
• platform/mediastream/mac/CoreAudioCaptureSource.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-03-22  Alex Christensen  <achristensen@webkit.org>
+
+        Add a few more WEBCORE_EXPORT macros
+        https://bugs.webkit.org/show_bug.cgi?id=238214
+
+        Reviewed by Eric Carlson.
+
+        These are needed to successfully link when building with -fsanitize=fuzzer,address
+
+        * dom/Document.h:
+        * html/HTMLCollection.h:
+        * html/HTMLOptionsCollection.h:
+        * platform/Pasteboard.h:
+        * platform/mediastream/mac/CoreAudioCaptureSource.h:
+
 2022-03-22  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/dom/Document.h

@@ -836 +836 @@
     void unregisterNodeListForInvalidation(LiveNodeList&);
     WEBCORE_EXPORT void registerCollection(HTMLCollection&);
-    void unregisterCollection(HTMLCollection&);
+    WEBCORE_EXPORT void unregisterCollection(HTMLCollection&);
     void collectionCachedIdNameMap(const HTMLCollection&);
     void collectionWillClearIdNameMap(const HTMLCollection&);

trunk/Source/WebCore/html/HTMLCollection.h

@@ -62 +62 @@
 // HTMLCollection subclasses NodeList to maintain legacy ObjC API compatibility.
 class HTMLCollection : public NodeList {
-    WTF_MAKE_ISO_ALLOCATED(HTMLCollection);
+    WTF_MAKE_ISO_ALLOCATED_EXPORT(HTMLCollection, WEBCORE_EXPORT);
 public:
-    virtual ~HTMLCollection();
+    WEBCORE_EXPORT virtual ~HTMLCollection();
 
     // DOM API
@@ -82 +82 @@
     ContainerNode& rootNode() const;
     void invalidateCacheForAttribute(const QualifiedName& attributeName);
-    virtual void invalidateCacheForDocument(Document&);
+    WEBCORE_EXPORT virtual void invalidateCacheForDocument(Document&);
     void invalidateCache() { invalidateCacheForDocument(document()); }
 
@@ -90 +90 @@
     HTMLCollection(ContainerNode& base, CollectionType);
 
-    virtual void updateNamedElementCache() const;
+    WEBCORE_EXPORT virtual void updateNamedElementCache() const;
     WEBCORE_EXPORT Element* namedItemSlow(const AtomString& name) const;
 

trunk/Source/WebCore/html/HTMLOptionsCollection.h

@@ -31 +31 @@
 
 class HTMLOptionsCollection final : public CachedHTMLCollection<HTMLOptionsCollection, CollectionTypeTraits<SelectOptions>::traversalType> {
-    WTF_MAKE_ISO_ALLOCATED(HTMLOptionsCollection);
+    WTF_MAKE_ISO_ALLOCATED_EXPORT(HTMLOptionsCollection, WEBCORE_EXPORT);
 public:
     using Base = CachedHTMLCollection<HTMLOptionsCollection, CollectionTypeTraits<SelectOptions>::traversalType>;

trunk/Source/WebCore/platform/Pasteboard.h

@@ -253 +253 @@
     WEBCORE_EXPORT static std::unique_ptr<Pasteboard> create(const DragData&);
 
-    virtual void setDragImage(DragImage, const IntPoint& hotSpot);
+    WEBCORE_EXPORT virtual void setDragImage(DragImage, const IntPoint& hotSpot);
 #endif
 

trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h

@@ -52 +52 @@
 class CoreAudioCaptureSource : public RealtimeMediaSource {
 public:
-    static CaptureSourceOrError create(String&& deviceID, String&& hashSalt, const MediaConstraints*, PageIdentifier);
+    WEBCORE_EXPORT static CaptureSourceOrError create(String&& deviceID, String&& hashSalt, const MediaConstraints*, PageIdentifier);
     static CaptureSourceOrError createForTesting(String&& deviceID, String&& label, String&& hashSalt, const MediaConstraints*, BaseAudioSharedUnit& overrideUnit, PageIdentifier);