Changeset 291754 in webkit

Timestamp:

Mar 23, 2022, 11:31:58 AM (5 years ago)

Author:

Brandon

Message:

WBR element should set Clear property to None
​https://bugs.webkit.org/show_bug.cgi?id=238275

Reviewed by Alan Bujtas.

WBR elements need to have their Clear property automatically set to None.
BR elements do not need this change.

• layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::BoxTree::buildTree):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/integration/LayoutIntegrationBoxTree.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-03-22  Brandon Stewart  <brandonstewart@apple.com>
+
+        WBR element should set Clear property to None
+        https://bugs.webkit.org/show_bug.cgi?id=238275
+
+        Reviewed by Alan Bujtas.
+
+        WBR elements need to have their Clear property automatically set to None.
+        BR elements do not need this change.
+
+        * layout/integration/LayoutIntegrationBoxTree.cpp:
+        (WebCore::LayoutIntegration::BoxTree::buildTree):
+
 2022-03-23  Kimmo Kinnunen  <kkinnunen@apple.com>
 

trunk/Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp

@@ -110 +110 @@
                 styleToAdjust.setFloating(Float::None);
                 styleToAdjust.setPosition(PositionType::Static);
+
+                // Clear property should only apply on block elements, however,
+                // it appears that browsers seem to ignore it on <br> inline elements.
+                // https://drafts.csswg.org/css2/#propdef-clear
+                if (downcast<RenderLineBreak>(childRenderer).isWBR())
+                    styleToAdjust.setClear(Clear::None);
             };
             adjustStyle(style);