Changeset 291755 in webkit

Timestamp:

Mar 23, 2022, 11:37:21 AM (5 years ago)

Author:

Chris Dumez

Message:

Avoid unnecessary String constructor under FunctionExecutable::toStringSlow()
​https://bugs.webkit.org/show_bug.cgi?id=238263

Reviewed by Darin Adler.

• runtime/FunctionExecutable.cpp:

(JSC::FunctionExecutable::toStringSlow):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/FunctionExecutable.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2022-03-23  Chris Dumez  <cdumez@apple.com>
+
+        Avoid unnecessary String constructor under FunctionExecutable::toStringSlow()
+        https://bugs.webkit.org/show_bug.cgi?id=238263
+
+        Reviewed by Darin Adler.
+
+        * runtime/FunctionExecutable.cpp:
+        (JSC::FunctionExecutable::toStringSlow):
+
 2022-03-23  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/runtime/FunctionExecutable.cpp

@@ -142 +142 @@
         return cache(jsString(vm, classSource().view().toString()));
 
-    String functionHeader;
+    ASCIILiteral functionHeader = ""_s;
     switch (parseMode()) {
     case SourceParseMode::GeneratorWrapperFunctionMode:
@@ -165 +165 @@
     case SourceParseMode::ArrowFunctionMode:
     case SourceParseMode::ClassFieldInitializerMode:
-        functionHeader = "";
         break;