Changeset 29179 in webkit

Timestamp:

Jan 4, 2008, 2:43:44 PM (18 years ago)

Author:

timothy@apple.com

Message:

Reviewed by Adam Roben.

<rdar://problem/5671059> Always show the Timeline and Console buttons in the Inspector

• page/inspector/inspector.css: Remove styles related to the toggle button and make the area always visible.
• page/inspector/inspector.html: Remove the toggle button.
• page/inspector/inspector.js: Remove code to toggle the status area.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/inspector/inspector.css (modified) (5 diffs)
• page/inspector/inspector.html (modified) (1 diff)
• page/inspector/inspector.js (modified) (8 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-01-04  Timothy Hatcher  <timothy@apple.com>
+
+        Reviewed by Adam Roben.
+
+        <rdar://problem/5671059> Always show the Timeline and Console buttons in the Inspector
+
+        * page/inspector/inspector.css: Remove styles related to the toggle button
+          and make the area always visible. 
+        * page/inspector/inspector.html: Remove the toggle button.
+        * page/inspector/inspector.js: Remove code to toggle the status area.
+
 2008-01-04  Alexey Proskuryakov  <ap@webkit.org>
 

trunk/WebCore/page/inspector/inspector.css

@@ -352 +352 @@
 }
 
-#statusbar #statusToggle {
-    background-image: url(Images/showStatusWidget.png);
-}
-
-#statusbar #statusToggle:active {
-    background-image: url(Images/showStatusWidgetPressed.png);
-}
-
-#statusbar #statusToggle.hide {
-    background-image: url(Images/hideStatusWidget.png);
-}
-
-#statusbar #statusToggle.hide:active {
-    background-image: url(Images/hideStatusWidgetPressed.png);
-}
-
 body.detached #attachToggle {
     background-image: url(Images/sidebarAttachWidget.png);
@@ -387 +371 @@
     overflow: hidden;
     position: absolute;
-    bottom: -57px;
+    bottom: 21px;
     left: 0;
     width: 100%;
@@ -398 +382 @@
     font-size: 11px;
     -webkit-transition: bottom 250ms ease-in-out;
-}
-
-#status.visible {
-    bottom: 21px;
 }
 
@@ -473 +453 @@
     top: 0;
     left: 0;
-    bottom: 21px;
+    bottom: 99px;
     width: 100%;
     padding: 2px 0;
@@ -481 +461 @@
     font-size: 11px;
     -webkit-transition: bottom 250ms ease-in-out;
-}
-
-#list.status-visible {
-    bottom: 99px;
 }
 

trunk/WebCore/page/inspector/inspector.html

@@ -62 +62 @@
         <ol id="status"></ol>
         <div id="statusbar">
-            <button id="statusToggle"></button><button id="attachToggle"></button>
+            <button id="attachToggle"></button>
             <span id="sidebarResizeWidget"></span>
         </div>

trunk/WebCore/page/inspector/inspector.js

@@ -148 +148 @@
     },
 
-    get showingStatusArea()
-    {
-        return this._showingStatusArea;
-    },
-
-    set showingStatusArea(x)
-    {
-        if (this._showingStatusArea === x)
-            return;
-
-        this._showingStatusArea = x;
-
-        var list = document.getElementById("list");
-        var status = document.getElementById("status");
-        var statusButton = document.getElementById("statusToggle");
-
-        if (x) {
-            statusButton.addStyleClass("hide");
-            list.addStyleClass("status-visible");
-            status.addStyleClass("visible");
-        } else {
-            statusButton.removeStyleClass("hide");
-            list.removeStyleClass("status-visible");
-            status.removeStyleClass("visible");
-        }
-    },
-
     get showingSearchResults()
     {
@@ -282 +255 @@
 
     document.getElementById("attachToggle").addEventListener("click", this.toggleAttach.bind(this), true);
-    document.getElementById("statusToggle").addEventListener("click", this.toggleStatusArea.bind(this), true);
 
     document.getElementById("sidebarResizeWidget").addEventListener("mousedown", this.sidebarResizerDragStart, true);
@@ -402 +374 @@
 
     if (this.fileOutline.selectedTreeElement) {
-        if (!this.fileOutline.handleKeyEvent(event) && event.keyIdentifier === "Down" && !event.altKey && this.showingStatusArea) {
+        if (!this.fileOutline.handleKeyEvent(event) && event.keyIdentifier === "Down" && !event.altKey) {
             var nextSelectedElement = this.statusOutline.children[0];
             while (nextSelectedElement && !nextSelectedElement.selectable)
@@ -408 +380 @@
         }
     } else if (this.statusOutline.selectedTreeElement) {
-        if (!this.showingStatusArea || (!this.statusOutline.handleKeyEvent(event) && event.keyIdentifier === "Up" && !event.altKey)) {
+        if (!this.statusOutline.handleKeyEvent(event) && event.keyIdentifier === "Up" && !event.altKey) {
             var nextSelectedElement = this.fileOutline.children[0];
             var lastSelectable = null;
@@ -540 +512 @@
 }
 
-WebInspector.toggleStatusArea = function()
-{
-    this.showingStatusArea = !this.showingStatusArea;
-}
-
 WebInspector.toolbarDragStart = function(event)
 {
@@ -698 +665 @@
 WebInspector.showConsole = function()
 {
-    this.showingStatusArea = true;
     this.navigateToPanel(WebInspector.consolePanel);
 }
@@ -704 +670 @@
 WebInspector.showTimeline = function()
 {
-    this.showingStatusArea = true;
     this.navigateToPanel(WebInspector.networkPanel);
 }
@@ -766 +731 @@
         case WebInspector.ConsoleMessage.MessageLevel.Warning:
             ++this.consoleListItem.warnings;
-            this.showingStatusArea = true;
             break;
         case WebInspector.ConsoleMessage.MessageLevel.Error:
             ++this.consoleListItem.errors;
-            this.showingStatusArea = true;
             break;
     }