Changeset 292043 in webkit

Timestamp:

Mar 29, 2022 10:55:21 AM (2 years ago)

Author:

Alan Bujtas

Message:

RenderText::width should call FontCascade directly on single space characters
​https://bugs.webkit.org/show_bug.cgi?id=238484

Reviewed by Antti Koivisto.

Some "text and inline box" heavy pages (e.g. wikipedia) have the pattern of leaving one space
gap between adjacent inline boxes (<span>some content</span> <span>and some more</span>).
This patch ensures that we don't construct redundant TextRun objects (and measure their widths)
for such simple cases when applicable.

• rendering/RenderText.cpp:

(WebCore::RenderText::width const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderText.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-03-29  Alan Bujtas  <zalan@apple.com>
+
+        RenderText::width should call FontCascade directly on single space characters
+        https://bugs.webkit.org/show_bug.cgi?id=238484
+
+        Reviewed by Antti Koivisto.
+
+        Some "text and inline box" heavy pages (e.g. wikipedia) have the pattern of leaving one space
+        gap between adjacent inline boxes (<span>some content</span> <span>and some more</span>).
+        This patch ensures that we don't construct redundant TextRun objects (and measure their widths) 
+        for such simple cases when applicable.
+
+        * rendering/RenderText.cpp:
+        (WebCore::RenderText::width const):
+
 2022-03-29  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebCore/rendering/RenderText.cpp

@@ -1561 +1561 @@
         return *width;
 
+    if (length == 1 && (characterAt(from) == space))
+        return canUseSimplifiedTextMeasuring() ? fontCascade.primaryFont().spaceWidth() : fontCascade.widthOfSpaceString();
+
     float width = 0.f;
     if (&fontCascade == &style.fontCascade()) {