Changeset 292054 in webkit

Timestamp:

Mar 29, 2022 12:10:01 PM (2 years ago)

Author:

Alan Bujtas

Message:

WebCore::LegacyRootInlineBox::lineSnapAdjustment should bail out on grid line height < 1
​https://bugs.webkit.org/show_bug.cgi?id=238465
<rdar://80630664>

Reviewed by Antti Koivisto.

The !gridLineHeight check was added to avoid division by zero but the integral roundToInt() may also produce a 0 value for
gridLineHeight.

• rendering/LegacyRootInlineBox.cpp:

(WebCore::LegacyRootInlineBox::lineSnapAdjustment const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/LegacyRootInlineBox.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-03-29  Alan Bujtas  <zalan@apple.com>
+
+        WebCore::LegacyRootInlineBox::lineSnapAdjustment should bail out on grid line height < 1
+        https://bugs.webkit.org/show_bug.cgi?id=238465
+        <rdar://80630664>
+
+        Reviewed by Antti Koivisto.
+
+        The !gridLineHeight check was added to avoid division by zero but the integral roundToInt() may also produce a 0 value for
+        gridLineHeight.
+
+        * rendering/LegacyRootInlineBox.cpp:
+        (WebCore::LegacyRootInlineBox::lineSnapAdjustment const):
+
 2022-03-29  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebCore/rendering/LegacyRootInlineBox.cpp

@@ -361 +361 @@
     // the grid should honor line-box-contain.
     LayoutUnit gridLineHeight = lineGridBox->lineBoxBottom() - lineGridBox->lineBoxTop();
-    if (!gridLineHeight)
+    if (!roundToInt(gridLineHeight))
         return 0;