⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 292185 in webkit


Ignore:
Timestamp:
Mar 31, 2022, 3:09:11 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, reverting r292119.
​https://bugs.webkit.org/show_bug.cgi?id=238638

New API test is flaky

Reverted changeset:

"Avoid initializing default WKWebsiteDataStore in
-[WKWebViewConfiguration copyWithZone]"
​https://bugs.webkit.org/show_bug.cgi?id=238531
​https://commits.webkit.org/r292119

Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r292184 r292185  
     12022-03-31  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, reverting r292119.
     4        https://bugs.webkit.org/show_bug.cgi?id=238638
     5
     6        New API test is flaky
     7
     8        Reverted changeset:
     9
     10        "Avoid initializing default WKWebsiteDataStore in
     11        -[WKWebViewConfiguration copyWithZone]"
     12        https://bugs.webkit.org/show_bug.cgi?id=238531
     13        https://commits.webkit.org/r292119
     14
    1152022-03-31  Wenson Hsieh  <wenson_hsieh@apple.com>
    216

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm

    r292119 r292185  
    336336        [NSException raise:NSInvalidArgumentException format:@"Configuration cannot be nil"];
    337337
    338     if (!configuration.websiteDataStore)
    339         [NSException raise:NSInvalidArgumentException format:@"Configuration websiteDataStore cannot be nil"];
    340338    _configuration = adoptNS([configuration copy]);
    341339

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm

    r292134 r292185  
    382382    configuration.preferences = self.preferences;
    383383    configuration.userContentController = self.userContentController;
    384     if (self._websiteDataStoreIfExists)
    385         [configuration setWebsiteDataStore:self._websiteDataStoreIfExists];
    386384    configuration.websiteDataStore = self.websiteDataStore;
    387385    configuration.defaultWebpagePreferences = self.defaultWebpagePreferences;

  • trunk/Tools/ChangeLog

    r292183 r292185  
     12022-03-31  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, reverting r292119.
     4        https://bugs.webkit.org/show_bug.cgi?id=238638
     5
     6        New API test is flaky
     7
     8        Reverted changeset:
     9
     10        "Avoid initializing default WKWebsiteDataStore in
     11        -[WKWebViewConfiguration copyWithZone]"
     12        https://bugs.webkit.org/show_bug.cgi?id=238531
     13        https://commits.webkit.org/r292119
     14
    1152022-03-31  Elliott Williams  <emw@apple.com>
    216

  • trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm

    r292119 r292185  
    414414}
    415415
    416 TEST(WKWebsiteDataStore, DoNotCreateDefaultDataStore)
    417 {
    418     auto configuration = adoptNS([WKWebViewConfiguration new]);
    419     [configuration.get() copy];
    420     EXPECT_FALSE([WKWebsiteDataStore _defaultDataStoreExists]);
    421 }
    422 
    423416} // namespace TestWebKitAPI
Note: See TracChangeset for help on using the changeset viewer.