Changeset 292195 in webkit

Timestamp:

Mar 31, 2022, 7:13:46 PM (5 years ago)

Author:

Jean-Yves Avenard

Message:

Player window shouldn't have black bar when going into fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=238592
rdar://91085981

Reviewed by Tim Horton.

Set the window size to the video element size when going fullscreen and
restore the original window size when coming out of it.

Manually tested.

• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm (modified) (4 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-03-31  Jean-Yves Avenard  <jya@apple.com>
+
+        Player window shouldn't have black bar when going into fullscreen
+        https://bugs.webkit.org/show_bug.cgi?id=238592
+        rdar://91085981
+
+        Reviewed by Tim Horton.
+
+        Set the window size to the video element size when going fullscreen and
+        restore the original window size when coming out of it.
+
+        Manually tested.
+
+        * UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
+        (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
+        (-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):
+
 2022-03-31  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm

@@ -462 +462 @@
     CGRect _initialFrame;
     CGRect _finalFrame;
+    CGRect _originalWindowFrame;
 
     RetainPtr<NSString> _EVOrganizationName;
@@ -635 +636 @@
     _initialFrame = initialFrame;
     _finalFrame = finalFrame;
+    _originalWindowFrame = [[_fullscreenViewController view] frame];
     
     _initialFrame.size = WebKit::sizeExpandedToSize(_initialFrame.size, CGSizeMake(1, 1));
@@ -672 +674 @@
 
 #if HAVE(UIKIT_WEBKIT_INTERNALS)
-            auto* view = [_fullscreenViewController view];
-            configureViewForEnteringFullscreen(view, kAnimationDuration, [view frame].size);
+            configureViewForEnteringFullscreen(_fullscreenViewController.get().view, kAnimationDuration, _finalFrame.size);
 #endif
 
@@ -789 +790 @@
     };
 #if HAVE(UIKIT_WEBKIT_INTERNALS)
-    configureViewForExitingFullscreen(_fullscreenViewController.get().view, kAnimationDuration, [[_fullscreenViewController view] frame].size, WTFMove(completionHandler));
+    configureViewForExitingFullscreen(_fullscreenViewController.get().view, kAnimationDuration, _originalWindowFrame.size, WTFMove(completionHandler));
 #else
     completionHandler();