Changeset 292270 in webkit


Ignore:
Timestamp:
Apr 2, 2022 2:03:18 PM (2 years ago)
Author:
Alan Bujtas
Message:

[Ruby] Remove incorrect implicit integral floor in RenderRubyText::adjustInlineDirectionLineBounds
https://bugs.webkit.org/show_bug.cgi?id=238671

Reviewed by Simon Fraser.

Source/WebCore:

In case of a fractional width value, the unintended integral flooring makes us believe we've got content overflow and we apply
a fractional inset which slightly moves the content in the inline direction.

  • rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::adjustInlineDirectionLineBounds const):

LayoutTests:

  • TestExpectations:
  • fast/ruby/bopomofo-mixed-expected.txt:
  • platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/mac/fast/ruby/bopomofo-expected.txt:
  • platform/mac/fast/ruby/bopomofo-letter-spacing-expected.txt:
  • platform/mac/fast/ruby/bopomofo-rl-expected.txt:
  • platform/mac/fast/ruby/ruby-run-break-expected.txt:
  • platform/mac/fast/ruby/ruby-runs-expected.txt:
  • platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/mac/fast/ruby/ruby-text-before-after-content-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
Location:
trunk
Files:
21 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r292268 r292270  
     12022-04-02  Alan Bujtas  <zalan@apple.com>
     2
     3        [Ruby] Remove incorrect implicit integral floor in RenderRubyText::adjustInlineDirectionLineBounds
     4        https://bugs.webkit.org/show_bug.cgi?id=238671
     5
     6        Reviewed by Simon Fraser.
     7
     8        * TestExpectations:
     9        * fast/ruby/bopomofo-mixed-expected.txt:
     10        * platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
     11        * platform/mac/fast/ruby/bopomofo-expected.txt:
     12        * platform/mac/fast/ruby/bopomofo-letter-spacing-expected.txt:
     13        * platform/mac/fast/ruby/bopomofo-rl-expected.txt:
     14        * platform/mac/fast/ruby/ruby-run-break-expected.txt:
     15        * platform/mac/fast/ruby/ruby-runs-expected.txt:
     16        * platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
     17        * platform/mac/fast/ruby/ruby-text-before-after-content-expected.txt:
     18        * platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
     19        * platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
     20
    1212022-04-02  Ziran Sun  <zsun@igalia.com>
    222
  • trunk/LayoutTests/TestExpectations

    r292268 r292270  
    46484648# webkit-ruby-text
    46494649imported/w3c/web-platform-tests/css/css-contain/contain-layout-017.html [ ImageOnlyFailure ]
    4650 imported/w3c/web-platform-tests/css/css-contain/contain-paint-008.html [ ImageOnlyFailure ]
    46514650imported/w3c/web-platform-tests/css/css-contain/contain-paint-021.html [ ImageOnlyFailure ]
    46524651imported/w3c/web-platform-tests/css/css-contain/contain-paint-clip-015.html [ ImageOnlyFailure ]
  • trunk/LayoutTests/fast/ruby/bopomofo-mixed-expected.txt

    r258990 r292270  
    1010              RenderRubyRun (anonymous) at (0,0) size 11x8
    1111                RenderRubyText {RT} at (10,0) size 10x8
    12                   RenderText {#text} at (0,3) size 9x3
    13                     text run at (0,3) width 3: "\x{2CB}"
     12                  RenderText {#text} at (0,2) size 9x4
     13                    text run at (0,2) width 3: "\x{2CB}"
    1414                RenderRubyBase (anonymous) at (0,0) size 11x8
    1515                  RenderText {#text} at (1,0) size 9x8
     
    2323              RenderRubyRun (anonymous) at (0,0) size 11x16
    2424                RenderRubyText {RT} at (10,0) size 10x16
    25                   RenderText {#text} at (0,7) size 9x3
    26                     text run at (0,7) width 3: "\x{2CB}"
     25                  RenderText {#text} at (0,6) size 9x4
     26                    text run at (0,6) width 3: "\x{2CB}"
    2727                RenderRubyBase (anonymous) at (0,0) size 11x16
    2828                  RenderText {#text} at (1,0) size 9x16
     
    3636              RenderRubyRun (anonymous) at (0,0) size 11x8
    3737                RenderRubyText {RT} at (10,0) size 10x8
    38                   RenderText {#text} at (0,3) size 9x3
    39                     text run at (0,3) width 3: "\x{2CA}"
     38                  RenderText {#text} at (0,2) size 9x4
     39                    text run at (0,2) width 3: "\x{2CA}"
    4040                RenderRubyBase (anonymous) at (0,0) size 11x8
    4141                  RenderText {#text} at (1,0) size 9x8
     
    4949              RenderRubyRun (anonymous) at (0,0) size 11x16
    5050                RenderRubyText {RT} at (10,0) size 10x16
    51                   RenderText {#text} at (0,7) size 9x3
    52                     text run at (0,7) width 3: "\x{2CA}"
     51                  RenderText {#text} at (0,6) size 9x4
     52                    text run at (0,6) width 3: "\x{2CA}"
    5353                RenderRubyBase (anonymous) at (0,0) size 11x16
    5454                  RenderText {#text} at (1,0) size 9x16
     
    6262              RenderRubyRun (anonymous) at (0,0) size 11x8
    6363                RenderRubyText {RT} at (10,0) size 10x8
    64                   RenderText {#text} at (0,3) size 9x3
    65                     text run at (0,3) width 3: "\x{2CB}"
     64                  RenderText {#text} at (0,2) size 9x4
     65                    text run at (0,2) width 3: "\x{2CB}"
    6666                RenderRubyBase (anonymous) at (0,0) size 11x8
    6767                  RenderText {#text} at (1,0) size 9x8
     
    8282              RenderRubyRun (anonymous) at (0,0) size 11x16
    8383                RenderRubyText {RT} at (10,0) size 10x16
    84                   RenderText {#text} at (0,7) size 9x3
    85                     text run at (0,7) width 3: "\x{2CB}"
     84                  RenderText {#text} at (0,6) size 9x4
     85                    text run at (0,6) width 3: "\x{2CB}"
    8686                RenderRubyBase (anonymous) at (0,0) size 11x16
    8787                  RenderText {#text} at (1,0) size 9x16
     
    9595              RenderRubyRun (anonymous) at (0,0) size 11x16
    9696                RenderRubyText {RT} at (10,0) size 9x16
    97                   RenderText {#text} at (0,7) size 9x3
    98                     text run at (0,7) width 3: "\x{2C7}"
     97                  RenderText {#text} at (0,6) size 9x4
     98                    text run at (0,6) width 3: "\x{2C7}"
    9999                RenderRubyBase (anonymous) at (0,0) size 11x16
    100100                  RenderText {#text} at (1,0) size 9x16
     
    115115              RenderRubyRun (anonymous) at (0,0) size 11x16
    116116                RenderRubyText {RT} at (10,0) size 10x16
    117                   RenderText {#text} at (0,7) size 9x3
    118                     text run at (0,7) width 3: "\x{2CA}"
     117                  RenderText {#text} at (0,6) size 9x4
     118                    text run at (0,6) width 3: "\x{2CA}"
    119119                RenderRubyBase (anonymous) at (0,0) size 11x16
    120120                  RenderText {#text} at (1,0) size 9x16
  • trunk/LayoutTests/platform/ios/fast/css/bidi-override-in-anonymous-block-expected.txt

    r286113 r292270  
    143143          RenderRubyRun (anonymous) at (89,29) size 13x0
    144144            RenderRubyText {RT} at (0,-11) size 12x12
    145               RenderText {#text} at (0,0) size 13x11
     145              RenderText {#text} at (0,0) size 12x11
    146146                text run at (0,0) width 12: "def"
    147147        RenderText {#text} at (84,12) size 5x19
  • trunk/LayoutTests/platform/ios/fast/ruby/bopomofo-expected.txt

    r258990 r292270  
    1010              RenderRubyRun (anonymous) at (0,0) size 12x8
    1111                RenderRubyText {RT} at (11,0) size 11x8
    12                   RenderText {#text} at (0,3) size 10x3
    13                     text run at (0,3) width 3: "\x{2CB}"
     12                  RenderText {#text} at (0,2) size 10x4
     13                    text run at (0,2) width 3: "\x{2CB}"
    1414                RenderRubyBase (anonymous) at (0,0) size 12x8
    1515                  RenderText {#text} at (1,0) size 10x8
     
    2323              RenderRubyRun (anonymous) at (0,0) size 12x16
    2424                RenderRubyText {RT} at (11,0) size 11x16
    25                   RenderText {#text} at (0,7) size 10x3
    26                     text run at (0,7) width 3: "\x{2CB}"
     25                  RenderText {#text} at (0,6) size 10x4
     26                    text run at (0,6) width 3: "\x{2CB}"
    2727                RenderRubyBase (anonymous) at (0,0) size 12x16
    2828                  RenderText {#text} at (1,0) size 10x16
     
    3636              RenderRubyRun (anonymous) at (0,0) size 12x8
    3737                RenderRubyText {RT} at (11,0) size 11x8
    38                   RenderText {#text} at (0,3) size 10x3
    39                     text run at (0,3) width 3: "\x{2CA}"
     38                  RenderText {#text} at (0,2) size 10x4
     39                    text run at (0,2) width 3: "\x{2CA}"
    4040                RenderRubyBase (anonymous) at (0,0) size 12x8
    4141                  RenderText {#text} at (1,0) size 10x8
     
    4949              RenderRubyRun (anonymous) at (0,0) size 12x16
    5050                RenderRubyText {RT} at (11,0) size 11x16
    51                   RenderText {#text} at (0,7) size 10x3
    52                     text run at (0,7) width 3: "\x{2CA}"
     51                  RenderText {#text} at (0,6) size 10x4
     52                    text run at (0,6) width 3: "\x{2CA}"
    5353                RenderRubyBase (anonymous) at (0,0) size 12x16
    5454                  RenderText {#text} at (1,0) size 10x16
     
    6262              RenderRubyRun (anonymous) at (0,0) size 12x8
    6363                RenderRubyText {RT} at (11,0) size 11x8
    64                   RenderText {#text} at (0,3) size 10x3
    65                     text run at (0,3) width 3: "\x{2CB}"
     64                  RenderText {#text} at (0,2) size 10x4
     65                    text run at (0,2) width 3: "\x{2CB}"
    6666                RenderRubyBase (anonymous) at (0,0) size 12x8
    6767                  RenderText {#text} at (1,0) size 10x8
     
    8282              RenderRubyRun (anonymous) at (0,0) size 12x16
    8383                RenderRubyText {RT} at (11,0) size 11x16
    84                   RenderText {#text} at (0,7) size 10x3
    85                     text run at (0,7) width 3: "\x{2CB}"
     84                  RenderText {#text} at (0,6) size 10x4
     85                    text run at (0,6) width 3: "\x{2CB}"
    8686                RenderRubyBase (anonymous) at (0,0) size 12x16
    8787                  RenderText {#text} at (1,0) size 10x16
     
    9595              RenderRubyRun (anonymous) at (0,0) size 12x16
    9696                RenderRubyText {RT} at (11,0) size 11x16
    97                   RenderText {#text} at (0,7) size 10x3
    98                     text run at (0,7) width 3: "\x{2C7}"
     97                  RenderText {#text} at (0,6) size 10x4
     98                    text run at (0,6) width 3: "\x{2C7}"
    9999                RenderRubyBase (anonymous) at (0,0) size 12x16
    100100                  RenderText {#text} at (1,0) size 10x16
     
    115115              RenderRubyRun (anonymous) at (0,0) size 12x16
    116116                RenderRubyText {RT} at (11,0) size 11x16
    117                   RenderText {#text} at (0,7) size 10x3
    118                     text run at (0,7) width 3: "\x{2CA}"
     117                  RenderText {#text} at (0,6) size 10x4
     118                    text run at (0,6) width 3: "\x{2CA}"
    119119                RenderRubyBase (anonymous) at (0,0) size 12x16
    120120                  RenderText {#text} at (1,0) size 10x16
  • trunk/LayoutTests/platform/ios/fast/ruby/bopomofo-letter-spacing-expected.txt

    r268958 r292270  
    1010              RenderRubyRun (anonymous) at (0,0) size 12x8
    1111                RenderRubyText {RT} at (11,0) size 11x8
    12                   RenderText {#text} at (0,3) size 10x3
    13                     text run at (0,3) width 3: "\x{2CB}"
     12                  RenderText {#text} at (0,2) size 10x4
     13                    text run at (0,2) width 3: "\x{2CB}"
    1414                RenderRubyBase (anonymous) at (0,0) size 12x8
    1515                  RenderText {#text} at (1,0) size 10x8
     
    2323              RenderRubyRun (anonymous) at (0,0) size 12x16
    2424                RenderRubyText {RT} at (11,0) size 11x16
    25                   RenderText {#text} at (0,7) size 10x3
    26                     text run at (0,7) width 3: "\x{2CB}"
     25                  RenderText {#text} at (0,6) size 10x4
     26                    text run at (0,6) width 3: "\x{2CB}"
    2727                RenderRubyBase (anonymous) at (0,0) size 12x16
    2828                  RenderText {#text} at (1,0) size 10x16
     
    3636              RenderRubyRun (anonymous) at (0,0) size 12x8
    3737                RenderRubyText {RT} at (11,0) size 11x8
    38                   RenderText {#text} at (0,3) size 10x3
    39                     text run at (0,3) width 3: "\x{2CA}"
     38                  RenderText {#text} at (0,2) size 10x4
     39                    text run at (0,2) width 3: "\x{2CA}"
    4040                RenderRubyBase (anonymous) at (0,0) size 12x8
    4141                  RenderText {#text} at (1,0) size 10x8
     
    4949              RenderRubyRun (anonymous) at (0,0) size 12x16
    5050                RenderRubyText {RT} at (11,0) size 11x16
    51                   RenderText {#text} at (0,7) size 10x3
    52                     text run at (0,7) width 3: "\x{2CA}"
     51                  RenderText {#text} at (0,6) size 10x4
     52                    text run at (0,6) width 3: "\x{2CA}"
    5353                RenderRubyBase (anonymous) at (0,0) size 12x16
    5454                  RenderText {#text} at (1,0) size 10x16
     
    6262              RenderRubyRun (anonymous) at (0,0) size 12x8
    6363                RenderRubyText {RT} at (11,0) size 11x8
    64                   RenderText {#text} at (0,3) size 10x3
    65                     text run at (0,3) width 3: "\x{2CB}"
     64                  RenderText {#text} at (0,2) size 10x4
     65                    text run at (0,2) width 3: "\x{2CB}"
    6666                RenderRubyBase (anonymous) at (0,0) size 12x8
    6767                  RenderText {#text} at (1,0) size 10x8
     
    8282              RenderRubyRun (anonymous) at (0,0) size 12x16
    8383                RenderRubyText {RT} at (11,0) size 11x16
    84                   RenderText {#text} at (0,7) size 10x3
    85                     text run at (0,7) width 3: "\x{2CB}"
     84                  RenderText {#text} at (0,6) size 10x4
     85                    text run at (0,6) width 3: "\x{2CB}"
    8686                RenderRubyBase (anonymous) at (0,0) size 12x16
    8787                  RenderText {#text} at (1,0) size 10x16
     
    9595              RenderRubyRun (anonymous) at (0,0) size 12x16
    9696                RenderRubyText {RT} at (11,0) size 11x16
    97                   RenderText {#text} at (0,7) size 10x3
    98                     text run at (0,7) width 3: "\x{2C7}"
     97                  RenderText {#text} at (0,6) size 10x4
     98                    text run at (0,6) width 3: "\x{2C7}"
    9999                RenderRubyBase (anonymous) at (0,0) size 12x16
    100100                  RenderText {#text} at (1,0) size 10x16
     
    115115              RenderRubyRun (anonymous) at (0,0) size 12x16
    116116                RenderRubyText {RT} at (11,0) size 11x16
    117                   RenderText {#text} at (0,7) size 10x3
    118                     text run at (0,7) width 3: "\x{2CA}"
     117                  RenderText {#text} at (0,6) size 10x4
     118                    text run at (0,6) width 3: "\x{2CA}"
    119119                RenderRubyBase (anonymous) at (0,0) size 12x16
    120120                  RenderText {#text} at (1,0) size 10x16
  • trunk/LayoutTests/platform/ios/fast/ruby/bopomofo-mixed-expected.txt

    r258990 r292270  
    1010              RenderRubyRun (anonymous) at (0,0) size 12x8
    1111                RenderRubyText {RT} at (11,0) size 11x8
    12                   RenderText {#text} at (0,3) size 10x3
    13                     text run at (0,3) width 3: "\x{2CB}"
     12                  RenderText {#text} at (0,2) size 10x4
     13                    text run at (0,2) width 3: "\x{2CB}"
    1414                RenderRubyBase (anonymous) at (0,0) size 12x8
    1515                  RenderText {#text} at (1,0) size 10x8
     
    2323              RenderRubyRun (anonymous) at (0,0) size 12x16
    2424                RenderRubyText {RT} at (11,0) size 11x16
    25                   RenderText {#text} at (0,7) size 10x3
    26                     text run at (0,7) width 3: "\x{2CB}"
     25                  RenderText {#text} at (0,6) size 10x4
     26                    text run at (0,6) width 3: "\x{2CB}"
    2727                RenderRubyBase (anonymous) at (0,0) size 12x16
    2828                  RenderText {#text} at (1,0) size 10x16
     
    3636              RenderRubyRun (anonymous) at (0,0) size 12x8
    3737                RenderRubyText {RT} at (11,0) size 11x8
    38                   RenderText {#text} at (0,3) size 10x3
    39                     text run at (0,3) width 3: "\x{2CA}"
     38                  RenderText {#text} at (0,2) size 10x4
     39                    text run at (0,2) width 3: "\x{2CA}"
    4040                RenderRubyBase (anonymous) at (0,0) size 12x8
    4141                  RenderText {#text} at (1,0) size 10x8
     
    4949              RenderRubyRun (anonymous) at (0,0) size 12x16
    5050                RenderRubyText {RT} at (11,0) size 11x16
    51                   RenderText {#text} at (0,7) size 10x3
    52                     text run at (0,7) width 3: "\x{2CA}"
     51                  RenderText {#text} at (0,6) size 10x4
     52                    text run at (0,6) width 3: "\x{2CA}"
    5353                RenderRubyBase (anonymous) at (0,0) size 12x16
    5454                  RenderText {#text} at (1,0) size 10x16
     
    6262              RenderRubyRun (anonymous) at (0,0) size 12x8
    6363                RenderRubyText {RT} at (11,0) size 11x8
    64                   RenderText {#text} at (0,3) size 10x3
    65                     text run at (0,3) width 3: "\x{2CB}"
     64                  RenderText {#text} at (0,2) size 10x4
     65                    text run at (0,2) width 3: "\x{2CB}"
    6666                RenderRubyBase (anonymous) at (0,0) size 12x8
    6767                  RenderText {#text} at (1,0) size 10x8
     
    8282              RenderRubyRun (anonymous) at (0,0) size 12x16
    8383                RenderRubyText {RT} at (11,0) size 11x16
    84                   RenderText {#text} at (0,7) size 10x3
    85                     text run at (0,7) width 3: "\x{2CB}"
     84                  RenderText {#text} at (0,6) size 10x4
     85                    text run at (0,6) width 3: "\x{2CB}"
    8686                RenderRubyBase (anonymous) at (0,0) size 12x16
    8787                  RenderText {#text} at (1,0) size 10x16
     
    9595              RenderRubyRun (anonymous) at (0,0) size 12x16
    9696                RenderRubyText {RT} at (11,0) size 11x16
    97                   RenderText {#text} at (0,7) size 10x3
    98                     text run at (0,7) width 3: "\x{2C7}"
     97                  RenderText {#text} at (0,6) size 10x4
     98                    text run at (0,6) width 3: "\x{2C7}"
    9999                RenderRubyBase (anonymous) at (0,0) size 12x16
    100100                  RenderText {#text} at (1,0) size 10x16
     
    115115              RenderRubyRun (anonymous) at (0,0) size 12x16
    116116                RenderRubyText {RT} at (11,0) size 11x16
    117                   RenderText {#text} at (0,7) size 10x3
    118                     text run at (0,7) width 3: "\x{2CA}"
     117                  RenderText {#text} at (0,6) size 10x4
     118                    text run at (0,6) width 3: "\x{2CA}"
    119119                RenderRubyBase (anonymous) at (0,0) size 12x16
    120120                  RenderText {#text} at (1,0) size 10x16
  • trunk/LayoutTests/platform/ios/fast/ruby/bopomofo-rl-expected.txt

    r258990 r292270  
    1010              RenderRubyRun (anonymous) at (0,12) size 12x8
    1111                RenderRubyText {RT} at (-9,0) size 11x8
    12                   RenderText {#text} at (0,3) size 10x3
    13                     text run at (0,3) width 3: "\x{2CB}"
     12                  RenderText {#text} at (0,2) size 10x4
     13                    text run at (0,2) width 3: "\x{2CB}"
    1414                RenderRubyBase (anonymous) at (0,0) size 12x8
    1515                  RenderText {#text} at (1,0) size 10x8
     
    2323              RenderRubyRun (anonymous) at (0,4) size 12x24
    2424                RenderRubyText {RT} at (-9,0) size 11x24
    25                   RenderText {#text} at (0,11) size 10x3
    26                     text run at (0,11) width 3: "\x{2CB}"
     25                  RenderText {#text} at (0,10) size 10x4
     26                    text run at (0,10) width 3: "\x{2CB}"
    2727                RenderRubyBase (anonymous) at (0,0) size 12x24
    2828                  RenderText {#text} at (1,0) size 10x24
     
    3636              RenderRubyRun (anonymous) at (0,12) size 12x8
    3737                RenderRubyText {RT} at (-9,0) size 11x8
    38                   RenderText {#text} at (0,3) size 10x3
    39                     text run at (0,3) width 3: "\x{2CA}"
     38                  RenderText {#text} at (0,2) size 10x4
     39                    text run at (0,2) width 3: "\x{2CA}"
    4040                RenderRubyBase (anonymous) at (0,0) size 12x8
    4141                  RenderText {#text} at (1,0) size 10x8
     
    4949              RenderRubyRun (anonymous) at (0,4) size 12x24
    5050                RenderRubyText {RT} at (-9,0) size 11x24
    51                   RenderText {#text} at (0,11) size 10x3
    52                     text run at (0,11) width 3: "\x{2CA}"
     51                  RenderText {#text} at (0,10) size 10x4
     52                    text run at (0,10) width 3: "\x{2CA}"
    5353                RenderRubyBase (anonymous) at (0,0) size 12x24
    5454                  RenderText {#text} at (1,0) size 10x24
     
    6262              RenderRubyRun (anonymous) at (0,12) size 12x8
    6363                RenderRubyText {RT} at (-9,0) size 11x8
    64                   RenderText {#text} at (0,3) size 10x3
    65                     text run at (0,3) width 3: "\x{2CB}"
     64                  RenderText {#text} at (0,2) size 10x4
     65                    text run at (0,2) width 3: "\x{2CB}"
    6666                RenderRubyBase (anonymous) at (0,0) size 12x8
    6767                  RenderText {#text} at (1,0) size 10x8
     
    7373          RenderRubyText {RT} at (-5,0) size 12x32
    7474            RenderText {#text} at (1,5) size 10x22
    75               text run at (1,5) width 21: "\x{3113}\x{2C7}"
     75              text run at (1,5) width 22: "\x{3113}\x{2C7}"
    7676          RenderRubyBase (anonymous) at (0,0) size 48x32
    7777            RenderText {#text} at (6,0) size 36x32
     
    8282              RenderRubyRun (anonymous) at (0,4) size 12x24
    8383                RenderRubyText {RT} at (-9,0) size 11x24
    84                   RenderText {#text} at (0,11) size 10x3
    85                     text run at (0,11) width 3: "\x{2CB}"
     84                  RenderText {#text} at (0,10) size 10x4
     85                    text run at (0,10) width 3: "\x{2CB}"
    8686                RenderRubyBase (anonymous) at (0,0) size 12x24
    8787                  RenderText {#text} at (1,0) size 10x24
     
    9595              RenderRubyRun (anonymous) at (0,4) size 12x24
    9696                RenderRubyText {RT} at (-9,0) size 11x24
    97                   RenderText {#text} at (0,11) size 10x3
    98                     text run at (0,11) width 3: "\x{2C7}"
     97                  RenderText {#text} at (0,10) size 10x4
     98                    text run at (0,10) width 3: "\x{2C7}"
    9999                RenderRubyBase (anonymous) at (0,0) size 12x24
    100100                  RenderText {#text} at (1,0) size 10x24
     
    115115              RenderRubyRun (anonymous) at (0,4) size 12x24
    116116                RenderRubyText {RT} at (-9,0) size 11x24
    117                   RenderText {#text} at (0,11) size 10x3
    118                     text run at (0,11) width 3: "\x{2CA}"
     117                  RenderText {#text} at (0,10) size 10x4
     118                    text run at (0,10) width 3: "\x{2CA}"
    119119                RenderRubyBase (anonymous) at (0,0) size 12x24
    120120                  RenderText {#text} at (1,0) size 10x24
  • trunk/LayoutTests/platform/ios/fast/ruby/ruby-text-before-after-content-expected.txt

    r179104 r292270  
    1010              RenderText at (0,0) size 62x19
    1111                text run at (0,0) width 62: "BEFORE"
    12             RenderText {#text} at (61,0) size 76x19
    13               text run at (61,0) width 76: "CONTENT"
    14             RenderInline (generated) at (0,0) size 52x19
    15               RenderText at (136,0) size 52x19
    16                 text run at (136,0) width 52: "AFTER"
     12            RenderText {#text} at (61,0) size 75x19
     13              text run at (61,0) width 75: "CONTENT"
     14            RenderInline (generated) at (0,0) size 51x19
     15              RenderText at (136,0) size 51x19
     16                text run at (136,0) width 51: "AFTER"
    1717          RenderRubyBase (anonymous) at (0,0) size 187x38
    1818            RenderText {#text} at (81,1) size 24x36
  • trunk/LayoutTests/platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt

    r286113 r292270  
    143143          RenderRubyRun (anonymous) at (89,27) size 13x0
    144144            RenderRubyText {RT} at (0,-10) size 12x10
    145               RenderText {#text} at (0,0) size 13x10
     145              RenderText {#text} at (0,0) size 12x10
    146146                text run at (0,0) width 12: "def"
    147147        RenderText {#text} at (84,11) size 5x18
  • trunk/LayoutTests/platform/mac/fast/ruby/bopomofo-expected.txt

    r258990 r292270  
    1010              RenderRubyRun (anonymous) at (0,0) size 11x8
    1111                RenderRubyText {RT} at (10,0) size 10x8
    12                   RenderText {#text} at (0,3) size 9x3
    13                     text run at (0,3) width 3: "\x{2CB}"
     12                  RenderText {#text} at (0,2) size 9x4
     13                    text run at (0,2) width 3: "\x{2CB}"
    1414                RenderRubyBase (anonymous) at (0,0) size 11x8
    1515                  RenderText {#text} at (1,0) size 9x8
     
    2323              RenderRubyRun (anonymous) at (0,0) size 11x16
    2424                RenderRubyText {RT} at (10,0) size 10x16
    25                   RenderText {#text} at (0,7) size 9x3
    26                     text run at (0,7) width 3: "\x{2CB}"
     25                  RenderText {#text} at (0,6) size 9x4
     26                    text run at (0,6) width 3: "\x{2CB}"
    2727                RenderRubyBase (anonymous) at (0,0) size 11x16
    2828                  RenderText {#text} at (1,0) size 9x16
     
    3636              RenderRubyRun (anonymous) at (0,0) size 11x8
    3737                RenderRubyText {RT} at (10,0) size 10x8
    38                   RenderText {#text} at (0,3) size 9x3
    39                     text run at (0,3) width 3: "\x{2CA}"
     38                  RenderText {#text} at (0,2) size 9x4
     39                    text run at (0,2) width 3: "\x{2CA}"
    4040                RenderRubyBase (anonymous) at (0,0) size 11x8
    4141                  RenderText {#text} at (1,0) size 9x8
     
    4949              RenderRubyRun (anonymous) at (0,0) size 11x16
    5050                RenderRubyText {RT} at (10,0) size 10x16
    51                   RenderText {#text} at (0,7) size 9x3
    52                     text run at (0,7) width 3: "\x{2CA}"
     51                  RenderText {#text} at (0,6) size 9x4
     52                    text run at (0,6) width 3: "\x{2CA}"
    5353                RenderRubyBase (anonymous) at (0,0) size 11x16
    5454                  RenderText {#text} at (1,0) size 9x16
     
    6262              RenderRubyRun (anonymous) at (0,0) size 11x8
    6363                RenderRubyText {RT} at (10,0) size 10x8
    64                   RenderText {#text} at (0,3) size 9x3
    65                     text run at (0,3) width 3: "\x{2CB}"
     64                  RenderText {#text} at (0,2) size 9x4
     65                    text run at (0,2) width 3: "\x{2CB}"
    6666                RenderRubyBase (anonymous) at (0,0) size 11x8
    6767                  RenderText {#text} at (1,0) size 9x8
     
    8282              RenderRubyRun (anonymous) at (0,0) size 11x16
    8383                RenderRubyText {RT} at (10,0) size 10x16
    84                   RenderText {#text} at (0,7) size 9x3
    85                     text run at (0,7) width 3: "\x{2CB}"
     84                  RenderText {#text} at (0,6) size 9x4
     85                    text run at (0,6) width 3: "\x{2CB}"
    8686                RenderRubyBase (anonymous) at (0,0) size 11x16
    8787                  RenderText {#text} at (1,0) size 9x16
     
    9595              RenderRubyRun (anonymous) at (0,0) size 11x16
    9696                RenderRubyText {RT} at (10,0) size 9x16
    97                   RenderText {#text} at (0,7) size 9x3
    98                     text run at (0,7) width 3: "\x{2C7}"
     97                  RenderText {#text} at (0,6) size 9x4
     98                    text run at (0,6) width 3: "\x{2C7}"
    9999                RenderRubyBase (anonymous) at (0,0) size 11x16
    100100                  RenderText {#text} at (1,0) size 9x16
     
    115115              RenderRubyRun (anonymous) at (0,0) size 11x16
    116116                RenderRubyText {RT} at (10,0) size 10x16
    117                   RenderText {#text} at (0,7) size 9x3
    118                     text run at (0,7) width 3: "\x{2CA}"
     117                  RenderText {#text} at (0,6) size 9x4
     118                    text run at (0,6) width 3: "\x{2CA}"
    119119                RenderRubyBase (anonymous) at (0,0) size 11x16
    120120                  RenderText {#text} at (1,0) size 9x16
  • trunk/LayoutTests/platform/mac/fast/ruby/bopomofo-letter-spacing-expected.txt

    r268958 r292270  
    1010              RenderRubyRun (anonymous) at (0,0) size 11x8
    1111                RenderRubyText {RT} at (10,0) size 10x8
    12                   RenderText {#text} at (0,3) size 9x3
    13                     text run at (0,3) width 3: "\x{2CB}"
     12                  RenderText {#text} at (0,2) size 9x4
     13                    text run at (0,2) width 3: "\x{2CB}"
    1414                RenderRubyBase (anonymous) at (0,0) size 11x8
    1515                  RenderText {#text} at (1,0) size 9x8
     
    2323              RenderRubyRun (anonymous) at (0,0) size 11x16
    2424                RenderRubyText {RT} at (10,0) size 10x16
    25                   RenderText {#text} at (0,7) size 9x3
    26                     text run at (0,7) width 3: "\x{2CB}"
     25                  RenderText {#text} at (0,6) size 9x4
     26                    text run at (0,6) width 3: "\x{2CB}"
    2727                RenderRubyBase (anonymous) at (0,0) size 11x16
    2828                  RenderText {#text} at (1,0) size 9x16
     
    3636              RenderRubyRun (anonymous) at (0,0) size 11x8
    3737                RenderRubyText {RT} at (10,0) size 10x8
    38                   RenderText {#text} at (0,3) size 9x3
    39                     text run at (0,3) width 3: "\x{2CA}"
     38                  RenderText {#text} at (0,2) size 9x4
     39                    text run at (0,2) width 3: "\x{2CA}"
    4040                RenderRubyBase (anonymous) at (0,0) size 11x8
    4141                  RenderText {#text} at (1,0) size 9x8
     
    4949              RenderRubyRun (anonymous) at (0,0) size 11x16
    5050                RenderRubyText {RT} at (10,0) size 10x16
    51                   RenderText {#text} at (0,7) size 9x3
    52                     text run at (0,7) width 3: "\x{2CA}"
     51                  RenderText {#text} at (0,6) size 9x4
     52                    text run at (0,6) width 3: "\x{2CA}"
    5353                RenderRubyBase (anonymous) at (0,0) size 11x16
    5454                  RenderText {#text} at (1,0) size 9x16
     
    6262              RenderRubyRun (anonymous) at (0,0) size 11x8
    6363                RenderRubyText {RT} at (10,0) size 10x8
    64                   RenderText {#text} at (0,3) size 9x3
    65                     text run at (0,3) width 3: "\x{2CB}"
     64                  RenderText {#text} at (0,2) size 9x4
     65                    text run at (0,2) width 3: "\x{2CB}"
    6666                RenderRubyBase (anonymous) at (0,0) size 11x8
    6767                  RenderText {#text} at (1,0) size 9x8
     
    8282              RenderRubyRun (anonymous) at (0,0) size 11x16
    8383                RenderRubyText {RT} at (10,0) size 10x16
    84                   RenderText {#text} at (0,7) size 9x3
    85                     text run at (0,7) width 3: "\x{2CB}"
     84                  RenderText {#text} at (0,6) size 9x4
     85                    text run at (0,6) width 3: "\x{2CB}"
    8686                RenderRubyBase (anonymous) at (0,0) size 11x16
    8787                  RenderText {#text} at (1,0) size 9x16
     
    9595              RenderRubyRun (anonymous) at (0,0) size 11x16
    9696                RenderRubyText {RT} at (10,0) size 9x16
    97                   RenderText {#text} at (0,7) size 9x3
    98                     text run at (0,7) width 3: "\x{2C7}"
     97                  RenderText {#text} at (0,6) size 9x4
     98                    text run at (0,6) width 3: "\x{2C7}"
    9999                RenderRubyBase (anonymous) at (0,0) size 11x16
    100100                  RenderText {#text} at (1,0) size 9x16
     
    115115              RenderRubyRun (anonymous) at (0,0) size 11x16
    116116                RenderRubyText {RT} at (10,0) size 10x16
    117                   RenderText {#text} at (0,7) size 9x3
    118                     text run at (0,7) width 3: "\x{2CA}"
     117                  RenderText {#text} at (0,6) size 9x4
     118                    text run at (0,6) width 3: "\x{2CA}"
    119119                RenderRubyBase (anonymous) at (0,0) size 11x16
    120120                  RenderText {#text} at (1,0) size 9x16
  • trunk/LayoutTests/platform/mac/fast/ruby/bopomofo-rl-expected.txt

    r258990 r292270  
    1010              RenderRubyRun (anonymous) at (0,12) size 11x8
    1111                RenderRubyText {RT} at (-8,0) size 10x8
    12                   RenderText {#text} at (0,3) size 9x3
    13                     text run at (0,3) width 3: "\x{2CB}"
     12                  RenderText {#text} at (0,2) size 9x4
     13                    text run at (0,2) width 3: "\x{2CB}"
    1414                RenderRubyBase (anonymous) at (0,0) size 11x8
    1515                  RenderText {#text} at (1,0) size 9x8
     
    2323              RenderRubyRun (anonymous) at (0,4) size 11x24
    2424                RenderRubyText {RT} at (-8,0) size 10x24
    25                   RenderText {#text} at (0,11) size 9x3
    26                     text run at (0,11) width 3: "\x{2CB}"
     25                  RenderText {#text} at (0,10) size 9x4
     26                    text run at (0,10) width 3: "\x{2CB}"
    2727                RenderRubyBase (anonymous) at (0,0) size 11x24
    2828                  RenderText {#text} at (1,0) size 9x24
     
    3636              RenderRubyRun (anonymous) at (0,12) size 11x8
    3737                RenderRubyText {RT} at (-8,0) size 10x8
    38                   RenderText {#text} at (0,3) size 9x3
    39                     text run at (0,3) width 3: "\x{2CA}"
     38                  RenderText {#text} at (0,2) size 9x4
     39                    text run at (0,2) width 3: "\x{2CA}"
    4040                RenderRubyBase (anonymous) at (0,0) size 11x8
    4141                  RenderText {#text} at (1,0) size 9x8
     
    4949              RenderRubyRun (anonymous) at (0,4) size 11x24
    5050                RenderRubyText {RT} at (-8,0) size 10x24
    51                   RenderText {#text} at (0,11) size 9x3
    52                     text run at (0,11) width 3: "\x{2CA}"
     51                  RenderText {#text} at (0,10) size 9x4
     52                    text run at (0,10) width 3: "\x{2CA}"
    5353                RenderRubyBase (anonymous) at (0,0) size 11x24
    5454                  RenderText {#text} at (1,0) size 9x24
     
    6262              RenderRubyRun (anonymous) at (0,12) size 11x8
    6363                RenderRubyText {RT} at (-8,0) size 10x8
    64                   RenderText {#text} at (0,3) size 9x3
    65                     text run at (0,3) width 3: "\x{2CB}"
     64                  RenderText {#text} at (0,2) size 9x4
     65                    text run at (0,2) width 3: "\x{2CB}"
    6666                RenderRubyBase (anonymous) at (0,0) size 11x8
    6767                  RenderText {#text} at (1,0) size 9x8
     
    7373          RenderRubyText {RT} at (-5,0) size 11x32
    7474            RenderText {#text} at (1,5) size 9x22
    75               text run at (1,5) width 21: "\x{3113}\x{2C7}"
     75              text run at (1,5) width 22: "\x{3113}\x{2C7}"
    7676          RenderRubyBase (anonymous) at (0,0) size 48x32
    7777            RenderText {#text} at (5,0) size 37x32
     
    8282              RenderRubyRun (anonymous) at (0,4) size 11x24
    8383                RenderRubyText {RT} at (-8,0) size 10x24
    84                   RenderText {#text} at (0,11) size 9x3
    85                     text run at (0,11) width 3: "\x{2CB}"
     84                  RenderText {#text} at (0,10) size 9x4
     85                    text run at (0,10) width 3: "\x{2CB}"
    8686                RenderRubyBase (anonymous) at (0,0) size 11x24
    8787                  RenderText {#text} at (1,0) size 9x24
     
    9595              RenderRubyRun (anonymous) at (0,4) size 11x24
    9696                RenderRubyText {RT} at (-8,0) size 9x24
    97                   RenderText {#text} at (0,11) size 9x3
    98                     text run at (0,11) width 3: "\x{2C7}"
     97                  RenderText {#text} at (0,10) size 9x4
     98                    text run at (0,10) width 3: "\x{2C7}"
    9999                RenderRubyBase (anonymous) at (0,0) size 11x24
    100100                  RenderText {#text} at (1,0) size 9x24
     
    115115              RenderRubyRun (anonymous) at (0,4) size 11x24
    116116                RenderRubyText {RT} at (-8,0) size 10x24
    117                   RenderText {#text} at (0,11) size 9x3
    118                     text run at (0,11) width 3: "\x{2CA}"
     117                  RenderText {#text} at (0,10) size 9x4
     118                    text run at (0,10) width 3: "\x{2CA}"
    119119                RenderRubyBase (anonymous) at (0,0) size 11x24
    120120                  RenderText {#text} at (1,0) size 9x24
  • trunk/LayoutTests/platform/mac/fast/ruby/ruby-run-break-expected.txt

    r268958 r292270  
    2525          RenderRubyRun (anonymous) at (187,12) size 17x18
    2626            RenderRubyText {RT} at (0,-10) size 16x10
    27               RenderText {#text} at (0,0) size 17x10
    28                 text run at (0,0) width 17: "Text"
     27              RenderText {#text} at (0,0) size 16x10
     28                text run at (0,0) width 16: "Text"
    2929            RenderRubyBase (anonymous) at (0,0) size 16x18
    3030              RenderText {#text} at (3,0) size 10x18
  • trunk/LayoutTests/platform/mac/fast/ruby/ruby-runs-expected.txt

    r268958 r292270  
    2222          RenderRubyRun (anonymous) at (175,10) size 17x18
    2323            RenderRubyText {RT} at (0,-10) size 16x10
    24               RenderText {#text} at (0,0) size 17x10
    25                 text run at (0,0) width 17: "Text"
     24              RenderText {#text} at (0,0) size 16x10
     25                text run at (0,0) width 16: "Text"
    2626            RenderRubyBase (anonymous) at (0,0) size 16x18
    2727              RenderText {#text} at (3,0) size 10x18
  • trunk/LayoutTests/platform/mac/fast/ruby/ruby-runs-spans-expected.txt

    r177774 r292270  
    1313          RenderRubyRun (anonymous) at (152,10) size 40x18
    1414            RenderRubyText {RT} at (0,-10) size 39x10
    15               RenderText {#text} at (0,0) size 40x10
    16                 text run at (0,0) width 40: "Hyper-text"
     15              RenderText {#text} at (0,0) size 39x10
     16                text run at (0,0) width 39: "Hyper-text"
    1717            RenderRubyBase (anonymous) at (0,0) size 39x18
    1818              RenderInline {SPAN} at (0,0) size 23x18
     
    2121          RenderRubyRun (anonymous) at (191,10) size 91x18
    2222            RenderRubyText {RT} at (0,-10) size 90x10
    23               RenderText {#text} at (0,0) size 91x10
    24                 text run at (0,0) width 91: "Markup Language Lvl. 5"
     23              RenderText {#text} at (0,0) size 90x10
     24                text run at (0,0) width 90: "Markup Language Lvl. 5"
    2525            RenderRubyBase (anonymous) at (0,0) size 90x18
    2626              RenderInline {SPAN} at (0,0) size 16x18
  • trunk/LayoutTests/platform/mac/fast/ruby/ruby-text-before-after-content-expected.txt

    r177774 r292270  
    1010              RenderText at (0,0) size 62x18
    1111                text run at (0,0) width 62: "BEFORE"
    12             RenderText {#text} at (61,0) size 76x18
    13               text run at (61,0) width 76: "CONTENT"
    14             RenderInline (generated) at (0,0) size 52x18
    15               RenderText at (136,0) size 52x18
    16                 text run at (136,0) width 52: "AFTER"
     12            RenderText {#text} at (61,0) size 75x18
     13              text run at (61,0) width 75: "CONTENT"
     14            RenderInline (generated) at (0,0) size 51x18
     15              RenderText at (136,0) size 51x18
     16                text run at (136,0) width 51: "AFTER"
    1717          RenderRubyBase (anonymous) at (0,0) size 187x37
    1818            RenderText {#text} at (81,0) size 24x37
  • trunk/LayoutTests/platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt

    r177774 r292270  
    1919          RenderRubyRun (anonymous) at (152,10) size 40x18
    2020            RenderRubyText {RT} at (0,-10) size 39x10
    21               RenderText {#text} at (0,0) size 40x10
    22                 text run at (0,0) width 40: "Hyper-text"
     21              RenderText {#text} at (0,0) size 39x10
     22                text run at (0,0) width 39: "Hyper-text"
    2323            RenderRubyBase (anonymous) at (0,0) size 39x18
    2424              RenderInline {SPAN} at (0,0) size 23x18
     
    4545          RenderRubyRun (anonymous) at (152,10) size 40x18
    4646            RenderRubyText {RT} at (0,-10) size 39x10
    47               RenderText {#text} at (0,0) size 40x10
    48                 text run at (0,0) width 40: "Hyper-text"
     47              RenderText {#text} at (0,0) size 39x10
     48                text run at (0,0) width 39: "Hyper-text"
    4949            RenderRubyBase (anonymous) at (0,0) size 39x18
    5050              RenderInline {SPAN} at (0,0) size 23x18
  • trunk/LayoutTests/platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt

    r177774 r292270  
    1919          RenderRubyRun (anonymous) at (152,10) size 40x18
    2020            RenderRubyText {RT} at (0,-10) size 39x10
    21               RenderText {#text} at (0,0) size 40x10
    22                 text run at (0,0) width 40: "Hyper-text"
     21              RenderText {#text} at (0,0) size 39x10
     22                text run at (0,0) width 39: "Hyper-text"
    2323            RenderRubyBase (anonymous) at (0,0) size 39x18
    2424              RenderText {#text} at (8,0) size 23x18
     
    4343          RenderRubyRun (anonymous) at (152,10) size 40x18
    4444            RenderRubyText {RT} at (0,-10) size 39x10
    45               RenderText {#text} at (0,0) size 40x10
    46                 text run at (0,0) width 40: "Hyper-text"
     45              RenderText {#text} at (0,0) size 39x10
     46                text run at (0,0) width 39: "Hyper-text"
    4747            RenderRubyBase (anonymous) at (0,0) size 39x18
    4848              RenderText {#text} at (8,0) size 23x18
  • trunk/Source/WebCore/ChangeLog

    r292268 r292270  
     12022-04-02  Alan Bujtas  <zalan@apple.com>
     2
     3        [Ruby] Remove incorrect implicit integral floor in RenderRubyText::adjustInlineDirectionLineBounds
     4        https://bugs.webkit.org/show_bug.cgi?id=238671
     5
     6        Reviewed by Simon Fraser.
     7
     8        In case of a fractional width value, the unintended integral flooring makes us believe we've got content overflow and we apply
     9        a fractional inset which slightly moves the content in the inline direction.
     10
     11        * rendering/RenderRubyText.cpp:
     12        (WebCore::RenderRubyText::adjustInlineDirectionLineBounds const):
     13
    1142022-04-02  Ziran Sun  <zsun@igalia.com>
    215
  • trunk/Source/WebCore/rendering/RenderRubyText.cpp

    r278253 r292270  
    7676        return RenderBlockFlow::adjustInlineDirectionLineBounds(expansionOpportunityCount, logicalLeft, logicalWidth);
    7777
    78     int maxPreferredLogicalWidth = this->maxPreferredLogicalWidth();
     78    auto maxPreferredLogicalWidth = this->maxPreferredLogicalWidth();
    7979    if (maxPreferredLogicalWidth >= logicalWidth)
    8080        return;
Note: See TracChangeset for help on using the changeset viewer.