⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 292284 in webkit


Ignore:
Timestamp:
Apr 4, 2022, 1:37:53 AM (4 years ago)
Author:
cathiechen
Message:

REGRESSION(r291797): [wk1] 5 contain-intrinsic-size* tests are constant text failures
​https://bugs.webkit.org/show_bug.cgi?id=238584

Reviewed by Simon Fraser.

Source/WTF:

Enable ResizeObserver for legacy WebKit.

  • Scripts/Preferences/WebPreferencesExperimental.yaml:

Tools:

Enable ResizeObserver for wk1 test.

  • DumpRenderTree/TestOptions.cpp:

(WTR::TestOptions::defaults):

LayoutTests:

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk1/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-031-expected.txt: Removed.
  • platform/mac-wk1/imported/w3c/web-platform-tests/resize-observer/change-layout-in-error-expected.txt: Removed.
Location:
trunk
Files:
2 deleted
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r292283 r292284  
     12022-04-04  Cathie Chen  <cathiechen@igalia.com>
     2
     3        REGRESSION(r291797): [wk1] 5 contain-intrinsic-size* tests are constant text failures
     4        https://bugs.webkit.org/show_bug.cgi?id=238584
     5
     6        Reviewed by Simon Fraser.
     7
     8        * platform/mac-wk1/TestExpectations:
     9        * platform/mac-wk1/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-031-expected.txt: Removed.
     10        * platform/mac-wk1/imported/w3c/web-platform-tests/resize-observer/change-layout-in-error-expected.txt: Removed.
     11
    1122022-04-04  Myles C. Maxfield  <mmaxfield@apple.com>
    213

  • trunk/LayoutTests/platform/mac-wk1/TestExpectations

    r292283 r292284  
    16951695
    16961696webkit.org/b/229247 http/tests/fetch/keepalive-fetch-2.html [ Pass Failure ]
    1697 
    1698 # webkit.org/b/238584 These 5 tests are constantly failing on wk1
    1699 imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-001.html [ Failure ]
    1700 imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-002.html [ Failure ]
    1701 imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-003.html [ Failure ]
    1702 imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-004.html [ Failure ]
    1703 imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-005.html [ Failure ]
    17041697
    17051698webkit.org/b/209878 [ Debug ] webrtc/datachannel/multiple-connections.html [ Pass Failure Slow ]

  • trunk/Source/WTF/ChangeLog

    r292275 r292284  
     12022-04-04  Cathie Chen  <cathiechen@igalia.com>
     2
     3        REGRESSION(r291797): [wk1] 5 contain-intrinsic-size* tests are constant text failures
     4        https://bugs.webkit.org/show_bug.cgi?id=238584
     5
     6        Reviewed by Simon Fraser.
     7
     8        Enable ResizeObserver for legacy WebKit.
     9
     10        * Scripts/Preferences/WebPreferencesExperimental.yaml:
     11
    1122022-04-03  Tim Horton  <timothy_horton@apple.com>
    213

  • trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml

    r292156 r292284  
    12201220      default: false
    12211221
    1222 # FIXME: This is on by default in WebKit2. Perhaps we should consider turning it on for WebKitLegacy as well.
    12231222ResizeObserverEnabled:
    12241223  type: bool
    … …  
    12271226  defaultValue:
    12281227    WebKitLegacy:
    1229       default: false
    1230     WebKit:
    1231       default: true
    1232     WebCore:
    1233       default: false
     1228      default: true
     1229    WebKit:
     1230      default: true
     1231    WebCore:
     1232      default: true
    12341233
    12351234ResolutionMediaFeatureEnabled:

  • trunk/Tools/ChangeLog

    r292274 r292284  
     12022-04-04  Cathie Chen  <cathiechen@igalia.com>
     2
     3        REGRESSION(r291797): [wk1] 5 contain-intrinsic-size* tests are constant text failures
     4        https://bugs.webkit.org/show_bug.cgi?id=238584
     5
     6        Reviewed by Simon Fraser.
     7
     8        Enable ResizeObserver for wk1 test.
     9
     10        * DumpRenderTree/TestOptions.cpp:
     11        (WTR::TestOptions::defaults):
     12
    1132022-04-02  Myles C. Maxfield  <mmaxfield@apple.com>
    214

  • trunk/Tools/DumpRenderTree/TestOptions.cpp

    r291578 r292284  
    120120            { "LazyImageLoadingEnabled", false },
    121121            { "RequestIdleCallbackEnabled", false },
    122             { "ResizeObserverEnabled", false },
    123122            { "WebAuthenticationEnabled", false },
    124123            { "WebGPUEnabled", false },
    … …  
    169168            { "PrivateClickMeasurementEnabled", false },
    170169            { "RequestIdleCallbackEnabled", false },
    171             { "ResizeObserverEnabled", false },
    172170            { "SelectionAcrossShadowBoundariesEnabled", true },
    173171            { "ShrinksStandaloneImagesToFit", true },
Note: See TracChangeset for help on using the changeset viewer.