Changeset 292351 in webkit

Timestamp:

Apr 4, 2022, 3:08:44 PM (5 years ago)

Author:

timothy_horton@apple.com

Message:

Remove the 'RB_full_manage_WK_jetsam' system feature flag and simplify adjacent logic
​https://bugs.webkit.org/show_bug.cgi?id=238760

Reviewed by Chris Dumez.

Source/WebKit:

• FeatureFlags/WebKit-appletvos.plist:
• FeatureFlags/WebKit-ios.plist:
• FeatureFlags/WebKit-macos.plist:
• FeatureFlags/WebKit-watchos.plist:
• UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:

(WebKit::shouldLeakBoost):

Source/WTF:

• wtf/PlatformHave.h:

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/PlatformHave.h (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/FeatureFlags/WebKit-appletvos.plist (modified) (1 diff)
• WebKit/FeatureFlags/WebKit-ios.plist (modified) (1 diff)
• WebKit/FeatureFlags/WebKit-macos.plist (modified) (1 diff)
• WebKit/FeatureFlags/WebKit-watchos.plist (modified) (1 diff)
• WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2022-04-04  Tim Horton  <timothy_horton@apple.com>
+
+        Remove the 'RB_full_manage_WK_jetsam' system feature flag and simplify adjacent logic
+        https://bugs.webkit.org/show_bug.cgi?id=238760
+
+        Reviewed by Chris Dumez.
+
+        * wtf/PlatformHave.h:
+
 2022-04-04  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WTF/wtf/PlatformHave.h

@@ -731 +731 @@
 #endif
 
-#if PLATFORM(IOS_FAMILY)
-#define HAVE_RUNNINGBOARD_WEBKIT_PRIORITY_SUPPORT 1
-#endif
-
 #if PLATFORM(IOS) || PLATFORM(MACCATALYST)
 #define HAVE_UI_EVENT_ATTRIBUTION 1

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-04-04  Tim Horton  <timothy_horton@apple.com>
+
+        Remove the 'RB_full_manage_WK_jetsam' system feature flag and simplify adjacent logic
+        https://bugs.webkit.org/show_bug.cgi?id=238760
+
+        Reviewed by Chris Dumez.
+
+        * FeatureFlags/WebKit-appletvos.plist:
+        * FeatureFlags/WebKit-ios.plist:
+        * FeatureFlags/WebKit-macos.plist:
+        * FeatureFlags/WebKit-watchos.plist:
+        * UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
+        (WebKit::shouldLeakBoost):
+
 2022-04-04  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist

@@ -78 +78 @@
                 <true/>
         </dict>
-        <key>RB_full_manage_WK_jetsam</key>
-        <dict>
-                <key>Enabled</key>
-                <true/>
-        </dict>
         <key>general_directory_for_storage</key>
         <dict>

trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist

@@ -78 +78 @@
                 <true/>
         </dict>
-        <key>RB_full_manage_WK_jetsam</key>
-        <dict>
-                <key>Enabled</key>
-                <true/>
-        </dict>
         <key>general_directory_for_storage</key>
         <dict>

trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist

@@ -83 +83 @@
                 <false/>
         </dict>
-        <key>RB_full_manage_WK_jetsam</key>
-        <dict>
-                <key>Enabled</key>
-                <true/>
-        </dict>
         <key>general_directory_for_storage</key>
         <dict>

trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist

@@ -78 +78 @@
                 <true/>
         </dict>
-        <key>RB_full_manage_WK_jetsam</key>
-        <dict>
-                <key>Enabled</key>
-                <true/>
-        </dict>
         <key>general_directory_for_storage</key>
         <dict>

trunk/Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm

@@ -85 +85 @@
 #if PLATFORM(IOS_FAMILY)
     UNUSED_PARAM(launchOptions);
-#if HAVE(RUNNINGBOARD_WEBKIT_PRIORITY_SUPPORT)
-    // On iOS, we don't need to leak a boost message when RunningBoard process assertions give us the
+    // On iOS, we don't need to leak a boost message because RunningBoard process assertions give us the
     // right priorities.
-    static const bool runningBoardHandlesPriorities = isFeatureFlagEnabled("RB_full_manage_WK_jetsam"_s);
-    return !runningBoardHandlesPriorities;
-#else
-    return true;
-#endif // HAVE(RUNNINGBOARD_WEBKIT_PRIORITY_SUPPORT)
+    return false;
 #else
     // On Mac, leak a boost onto the NetworkProcess, GPUProcess, and WebAuthnProcess.