Changeset 292562 in webkit


Ignore:
Timestamp:
Apr 7, 2022 1:36:29 PM (2 years ago)
Author:
Alan Bujtas
Message:

Unreviewed test gardening.

  • imported/blink/fast/multicol/vertical-lr/float-content-break-expected.html:

.html is rendered using the legacy codepath while -expected.html is renderer using the modern codepath.
In case of fractional pixel values, they sometimes produce different final baselines due to (unintentional) implicit flooring in legacy line layout.
While most of these intentional/unintentional floors/ceils are matched (with FIXMEs) in the modern line layout, some would make the line layout
codebase a lot more complicated. These type of bugs are mostly not visible to the user anyway ever since we have stopped swapping between modern
and legacy line layout dynamically (e.g. on selection).

  • imported/blink/fast/multicol/vertical-lr/float-content-break.html:
  • platform/ios-wk2/TestExpectations:
  • platform/ios/TestExpectations:
Location:
trunk/LayoutTests
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r292559 r292562  
     12022-04-07  Alan Bujtas  <zalan@apple.com>
     2
     3        Unreviewed test gardening.
     4
     5        * imported/blink/fast/multicol/vertical-lr/float-content-break-expected.html:
     6        .html is rendered using the legacy codepath while -expected.html is renderer using the modern codepath.
     7        In case of fractional pixel values, they sometimes produce different final baselines due to (unintentional) implicit flooring in legacy line layout.
     8        While most of these intentional/unintentional floors/ceils are matched (with FIXMEs) in the modern line layout, some would make the line layout
     9        codebase a lot more complicated. These type of bugs are mostly not visible to the user anyway ever since we have stopped swapping between modern
     10        and legacy line layout dynamically (e.g. on selection).
     11        * imported/blink/fast/multicol/vertical-lr/float-content-break.html:
     12        * platform/ios-wk2/TestExpectations:
     13        * platform/ios/TestExpectations:
     14
    1152022-04-07  Tim Nguyen  <ntim@apple.com>
    216

  • trunk/LayoutTests/imported/blink/fast/multicol/vertical-lr/float-content-break-expected.html

    r190629 r292562  
    33    body {
    44        -webkit-writing-mode: vertical-lr;
     5        font-size: 15px;
    56    }
    67    .multicol {

  • trunk/LayoutTests/imported/blink/fast/multicol/vertical-lr/float-content-break.html

    r190629 r292562  
    33    body {
    44        -webkit-writing-mode: vertical-lr;
     5        font-size: 15px;
    56    }
    67    .multicol {

  • trunk/LayoutTests/platform/ios-wk2/TestExpectations

    r292553 r292562  
    22092209webkit.org/b/234536 webxr/high-performance.html [ Failure ]
    22102210
    2211 # Wrong text color
    2212 webkit.org/b/236913 imported/blink/fast/multicol/vertical-lr/float-content-break.html [ ImageOnlyFailure ]
    2213 
    22142211# Media failures
    22152212webkit.org/b/237295 fast/mediastream/video-rotation-gpu-process-crash.html [ Timeout Crash Pass ]

  • trunk/LayoutTests/platform/ios/TestExpectations

    r292409 r292562  
    21822182imported/blink/fast/multicol/vertical-lr/float-big-line.html [ ImageOnlyFailure ]
    21832183imported/blink/fast/multicol/vertical-lr/float-break.html [ ImageOnlyFailure ]
    2184 imported/blink/fast/multicol/vertical-lr/float-content-break.html [ ImageOnlyFailure ]
    21852184imported/blink/fast/multicol/vertical-lr/float-edge.html [ ImageOnlyFailure ]
    21862185imported/blink/fast/pagination/div-x-vertical-lr-ltr.html [ ImageOnlyFailure ]
Note: See TracChangeset for help on using the changeset viewer.