Changeset 292903 in webkit

Timestamp:

Apr 15, 2022, 2:53:12 AM (4 years ago)

Author:

zan@falconsigh.net

Message:

[GTK][WPE] Remove exclusive build guards around GPU process preferences, code
​https://bugs.webkit.org/show_bug.cgi?id=239331

Reviewed by Philippe Normand.

Source/WebKit:

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createGraphicsContextGL const):
Remove restrictive guards around the check for remote-WebGL execution,
only remaining guard being ENABLE(GPU_PROCESS).

Source/WTF:

• Scripts/Preferences/WebPreferencesExperimental.yaml:

Make the UseGPUProcessForWebGLEnabled option also usable for the GTK and
WPE ports.

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2022-04-15  Zan Dobersek  <zdobersek@igalia.com>
+
+        [GTK][WPE] Remove exclusive build guards around GPU process preferences, code
+        https://bugs.webkit.org/show_bug.cgi?id=239331
+
+        Reviewed by Philippe Normand.
+
+        * Scripts/Preferences/WebPreferencesExperimental.yaml:
+        Make the UseGPUProcessForWebGLEnabled option also usable for the GTK and
+        WPE ports.
+
 2022-04-14  J Pascoe  <j_pascoe@apple.com>
 

trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml

@@ -1463 +1463 @@
   humanReadableDescription: "Process all WebGL operations in GPU Process"
   webcoreBinding: none
-  condition: ENABLE(GPU_PROCESS) && ENABLE(WEBGL) && !(PLATFORM(GTK) || PLATFORM(WPE))
+  condition: ENABLE(GPU_PROCESS) && ENABLE(WEBGL)
   exposed: [ WebKit ]
   defaultValue:

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-04-15  Zan Dobersek  <zdobersek@igalia.com>
+
+        [GTK][WPE] Remove exclusive build guards around GPU process preferences, code
+        https://bugs.webkit.org/show_bug.cgi?id=239331
+
+        Reviewed by Philippe Normand.
+
+        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+        (WebKit::WebChromeClient::createGraphicsContextGL const):
+        Remove restrictive guards around the check for remote-WebGL execution,
+        only remaining guard being ENABLE(GPU_PROCESS).
+
 2022-04-14  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp

@@ -122 +122 @@
 #endif
 
-#if ENABLE(WEBGL) && ENABLE(GPU_PROCESS) && (PLATFORM(COCOA) || PLATFORM(WIN))
+#if ENABLE(WEBGL) && ENABLE(GPU_PROCESS)
 #include "RemoteGraphicsContextGLProxy.h"
 #endif
@@ -949 +949 @@
 RefPtr<GraphicsContextGL> WebChromeClient::createGraphicsContextGL(const GraphicsContextGLAttributes& attributes) const
 {
-#if ENABLE(GPU_PROCESS) && (PLATFORM(COCOA) || PLATFORM(WIN))
+#if ENABLE(GPU_PROCESS)
     if (WebProcess::singleton().shouldUseRemoteRenderingForWebGL())
         return RemoteGraphicsContextGLProxy::create(attributes, m_page.ensureRemoteRenderingBackendProxy().ensureBackendCreated());