Changeset 293286 in webkit

Timestamp:

Apr 22, 2022, 9:40:17 PM (4 years ago)

Author:

Simon Fraser

Message:

Crash under AsyncScrollingCoordinator::scrollingThreadAddedPendingUpdate()
​https://bugs.webkit.org/show_bug.cgi?id=239683
<rdar://92198272>

Reviewed by Alan Bujtas.

Crash data suggest that m_page can be null in
AsyncScrollingCoordinator::scheduleRenderingUpdate(), which does seem possible because
scheduleRenderingUpdate() is a dispatch from the scrolling thread, and
ScrollingCoordinator::pageDestroyed() may have run before it runs.

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::scheduleRenderingUpdate):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/scrolling/AsyncScrollingCoordinator.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-04-22  Simon Fraser  <simon.fraser@apple.com>
+
+        Crash under AsyncScrollingCoordinator::scrollingThreadAddedPendingUpdate()
+        https://bugs.webkit.org/show_bug.cgi?id=239683
+        <rdar://92198272>
+
+        Reviewed by Alan Bujtas.
+
+        Crash data suggest that m_page can be null in
+        AsyncScrollingCoordinator::scheduleRenderingUpdate(), which does seem possible because
+        scheduleRenderingUpdate() is a dispatch from the scrolling thread, and
+        ScrollingCoordinator::pageDestroyed() may have run before it runs.
+
+        * page/scrolling/AsyncScrollingCoordinator.cpp:
+        (WebCore::AsyncScrollingCoordinator::scheduleRenderingUpdate):
+
 2022-04-22  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp

@@ -374 +374 @@
 void AsyncScrollingCoordinator::scheduleRenderingUpdate()
 {
-    m_page->scheduleRenderingUpdate(RenderingUpdateStep::ScrollingTreeUpdate);
+    if (m_page)
+        m_page->scheduleRenderingUpdate(RenderingUpdateStep::ScrollingTreeUpdate);
 }