Changeset 293287 in webkit

Timestamp:

Apr 22, 2022, 11:27:11 PM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Should never be reached failure in WebCore::RenderElement::visibleInViewportStateChanged
​https://bugs.webkit.org/show_bug.cgi?id=191824

Patch by Rob Buis <​rbuis@igalia.com> on 2022-04-22
Reviewed by Eric Carlson.

Source/WebCore:

Provide an empty visibleInViewportStateChanged implementation
for RenderMedia to prevent hitting the ASSERT.

Test: media/audio-viewport-state-change-crash.html

• rendering/RenderMedia.h:

LayoutTests:

• media/audio-viewport-state-change-crash-expected.txt: Added.
• media/audio-viewport-state-change-crash.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/audio-viewport-state-change-crash-expected.txt (added)
• LayoutTests/media/audio-viewport-state-change-crash.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderMedia.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2022-04-22  Rob Buis  <rbuis@igalia.com>
+
+        Should never be reached failure in WebCore::RenderElement::visibleInViewportStateChanged
+        https://bugs.webkit.org/show_bug.cgi?id=191824
+
+        Reviewed by Eric Carlson.
+
+        * media/audio-viewport-state-change-crash-expected.txt: Added.
+        * media/audio-viewport-state-change-crash.html: Added.
+
 2022-04-22  Patrick Angle  <pangle@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-04-22  Rob Buis  <rbuis@igalia.com>
+
+        Should never be reached failure in WebCore::RenderElement::visibleInViewportStateChanged
+        https://bugs.webkit.org/show_bug.cgi?id=191824
+
+        Reviewed by Eric Carlson.
+
+        Provide an empty visibleInViewportStateChanged implementation
+        for RenderMedia to prevent hitting the ASSERT.
+
+        Test: media/audio-viewport-state-change-crash.html
+
+        * rendering/RenderMedia.h:
+
 2022-04-22  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/rendering/RenderMedia.h

@@ -47 +47 @@
     void layout() override;
 
+    void visibleInViewportStateChanged() override { }
+
 private:
     void element() const = delete;