⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 293289 in webkit


Ignore:
Timestamp:
Apr 23, 2022, 1:10:09 AM (4 years ago)
Author:
commit-queue@webkit.org
Message:

[ATSPI] WTR: add implementation for AccessibilityUIElement::domIdentifier
​https://bugs.webkit.org/show_bug.cgi?id=239598

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2022-04-23
Reviewed by Andres Gonzalez.

Tools:

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::domIdentifier const): Deleted.

  • WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:

(WTR::AccessibilityUIElement::domIdentifier const):

  • WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:

(WTR::AccessibilityUIElement::domIdentifier const):

LayoutTests:

  • platform/glib/accessibility/table-add-remove-row-expected.txt: Removed.
Location:
trunk
Files:
1 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r293287 r293289  
     12022-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [ATSPI] WTR: add implementation for AccessibilityUIElement::domIdentifier
     4        https://bugs.webkit.org/show_bug.cgi?id=239598
     5
     6        Reviewed by Andres Gonzalez.
     7
     8        * platform/glib/accessibility/table-add-remove-row-expected.txt: Removed.
     9
    1102022-04-22  Rob Buis  <rbuis@igalia.com>
    211

  • trunk/Tools/ChangeLog

    r293285 r293289  
     12022-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [ATSPI] WTR: add implementation for AccessibilityUIElement::domIdentifier
     4        https://bugs.webkit.org/show_bug.cgi?id=239598
     5
     6        Reviewed by Andres Gonzalez.
     7
     8        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
     9        (WTR::AccessibilityUIElement::domIdentifier const): Deleted.
     10        * WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
     11        (WTR::AccessibilityUIElement::domIdentifier const):
     12        * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
     13        (WTR::AccessibilityUIElement::domIdentifier const):
     14
    1152022-04-22  Chris Dumez  <cdumez@apple.com>
    216

  • trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp

    r288168 r293289  
    121121bool AccessibilityUIElement::isInCell() const { return false; }
    122122
    123 JSRetainPtr<JSStringRef> AccessibilityUIElement::domIdentifier() const { return nullptr; }
    124123JSRetainPtr<JSStringRef> AccessibilityUIElement::sortDirection() const { return nullptr; }
    125124JSRetainPtr<JSStringRef> AccessibilityUIElement::lineRectsAndText() const { return { }; }

  • trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp

    r293056 r293289  
    445445    auto value = m_element->attributes().get("current"_s);
    446446    return OpaqueJSString::tryCreate(!value.isNull() ? value : "false"_s).leakRef();
     447}
     448
     449JSRetainPtr<JSStringRef> AccessibilityUIElement::domIdentifier() const
     450{
     451    m_element->updateBackingStore();
     452    return OpaqueJSString::tryCreate(m_element->attributes().get("id"_s)).leakRef();
    447453}
    448454

  • trunk/Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp

    r293006 r293289  
    10161016}
    10171017
     1018JSRetainPtr<JSStringRef> AccessibilityUIElement::domIdentifier() const
     1019{
     1020    notImplemented();
     1021    return nullptr;
     1022}
     1023
    10181024} // namespace  WTF
    10191025
Note: See TracChangeset for help on using the changeset viewer.