Changeset 293294 in webkit

Timestamp:

Apr 23, 2022, 2:13:57 PM (4 years ago)

Author:

Elliott Williams

Message:

[buildbot] Increase the EWS compile timeout to account for delayed output from clang/XCBuild
​https://bugs.webkit.org/show_bug.cgi?id=239455

Reviewed by Ryan Haddad.

Same as ​https://commits.webkit.org/249737@main, needed to work around
delayed output bugs in Xcode/XCBuild.

• Tools/CISupport/ews-build/steps.py:

(CompileWebKit.init):

• Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: ​https://commits.webkit.org/249919@main

Location:

trunk/Tools

Files:

• CISupport/ews-build/steps.py (modified) (1 diff)
• CISupport/ews-build/steps_unittest.py (modified) (10 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/CISupport/ews-build/steps.py

@@ -2296 +2296 @@
     def __init__(self, skipUpload=False, **kwargs):
         self.skipUpload = skipUpload
+        # https://bugs.webkit.org/show_bug.cgi?id=239455: The timeout needs to be >20 min to work
+        # around log output delays on slower machines.
+        kwargs.setdefault('timeout', 60 * 30)
         super(CompileWebKit, self).__init__(logEnviron=False, **kwargs)
 

trunk/Tools/CISupport/ews-build/steps_unittest.py

@@ -1167 +1167 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-webkit', '--release'],
@@ -1182 +1183 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-webkit', '--release', '--prefix=/app/webkit/WebKitBuild/release/install', '--gtk'],
@@ -1197 +1199 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-webkit', '--release', '--wpe'],
@@ -1211 +1214 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-webkit', '--debug'],
@@ -1243 +1247 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-webkit', '--release'],
@@ -1257 +1262 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-webkit', '--debug'],
@@ -1367 +1373 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-jsc', '--release'],
@@ -1381 +1388 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-jsc', '--debug'],
@@ -1405 +1413 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-jsc', '--release'],
@@ -1419 +1428 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-jsc', '--debug'],

trunk/Tools/ChangeLog

@@ +1 @@
+2022-04-23  Elliott Williams  <emw@apple.com>
+
+        [buildbot] Increase the EWS compile timeout to account for delayed output from clang/XCBuild
+        https://bugs.webkit.org/show_bug.cgi?id=239455
+
+        Reviewed by Ryan Haddad.
+
+        Same as https://commits.webkit.org/249737@main, needed to work around
+        delayed output bugs in Xcode/XCBuild.
+
+        * CISupport/ews-build/steps.py:
+        (CompileWebKit.__init__):
+        * CISupport/ews-build/steps_unittest.py:
+
 2022-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>