Changeset 293307 in webkit

Timestamp:

Apr 24, 2022, 2:16:48 PM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Use utf-8 for text mode files in generate-automation-atom.py
​https://bugs.webkit.org/show_bug.cgi?id=239542

Patch by Daniel Kolesa <Daniel Kolesa> on 2022-04-24
Reviewed by Adrian Perez de Castro.

At least with older versions of python (3.6), this will otherwise
be ascii, which will break input files that contain non-ascii
characters, e.g. Source/WebKit/UIProcess/Automation/atoms/FindNodes.js

• Scripts/generate-automation-atom.py:

(main):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Scripts/generate-automation-atom.py (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-04-24  Daniel Kolesa  <dkolesa@igalia.com>
+
+        Use utf-8 for text mode files in generate-automation-atom.py
+        https://bugs.webkit.org/show_bug.cgi?id=239542
+
+        Reviewed by Adrian Perez de Castro.
+
+        At least with older versions of python (3.6), this will otherwise
+        be ascii, which will break input files that contain non-ascii
+        characters, e.g. Source/WebKit/UIProcess/Automation/atoms/FindNodes.js
+
+        * Scripts/generate-automation-atom.py:
+        (main):
+
 2022-04-23  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/Scripts/generate-automation-atom.py

@@ -76 +76 @@
     utils = os.path.join(os.path.dirname(input), "utils.js")
 
-    with open(input, "r") as fd:
+    with open(input, "r", encoding="utf-8") as fd:
         input_data = fd.read()
 
@@ -88 +88 @@
         input_data = input_data.replace('"use strict";\n', '"use strict";\n\n' + "\n".join(utils_data))
 
-    with open(output, "w") as fd:
+    with open(output, "w", encoding="utf-8") as fd:
         fd.write(input_data)