Changeset 293313 in webkit

Timestamp:

Apr 24, 2022, 11:29:19 PM (4 years ago)

Author:

zan@falconsigh.net

Message:

[RISCV64] Implement MacroAssemblerRISCV64 fencing methods
​https://bugs.webkit.org/show_bug.cgi?id=239706

Reviewed by Yusuke Suzuki.

Provide MacroAssemblerRISCV64 implementations for the tree fencing
methods, using the fence instruction but with different corresponding
combinations of the predecessor and successor operation sets.

• assembler/MacroAssemblerRISCV64.h:

(JSC::MacroAssemblerRISCV64::memoryFence):
(JSC::MacroAssemblerRISCV64::storeFence):
(JSC::MacroAssemblerRISCV64::loadFence):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/MacroAssemblerRISCV64.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2022-04-24  Zan Dobersek  <zdobersek@igalia.com>
+
+        [RISCV64] Implement MacroAssemblerRISCV64 fencing methods
+        https://bugs.webkit.org/show_bug.cgi?id=239706
+
+        Reviewed by Yusuke Suzuki.
+
+        Provide MacroAssemblerRISCV64 implementations for the tree fencing
+        methods, using the `fence` instruction but with different corresponding
+        combinations of the predecessor and successor operation sets.
+
+        * assembler/MacroAssemblerRISCV64.h:
+        (JSC::MacroAssemblerRISCV64::memoryFence):
+        (JSC::MacroAssemblerRISCV64::storeFence):
+        (JSC::MacroAssemblerRISCV64::loadFence):
+
 2022-04-22  Diego Pino Garcia  <dpino@igalia.com>
 

trunk/Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h

@@ -3286 +3286 @@
     }
 
-    void memoryFence() { }
-    void storeFence() { }
-    void loadFence() { }
+    void memoryFence()
+    {
+        m_assembler.fenceInsn({ RISCV64Assembler::MemoryOperation::RW }, { RISCV64Assembler::MemoryOperation::RW });
+    }
+
+    void storeFence()
+    {
+        m_assembler.fenceInsn({ RISCV64Assembler::MemoryOperation::W }, { RISCV64Assembler::MemoryOperation::RW });
+    }
+
+    void loadFence()
+    {
+        m_assembler.fenceInsn({ RISCV64Assembler::MemoryOperation::R }, { RISCV64Assembler::MemoryOperation::RW });
+    }
 
     MACRO_ASSEMBLER_RISCV64_TEMPLATED_NOOP_METHOD_WITH_RETURN(branchAtomicWeakCAS8, JumpList);