Changeset 293316 in webkit

Timestamp:

Apr 24, 2022, 11:54:42 PM (4 years ago)

Author:

zan@falconsigh.net

Message:

[RISCV64] Enable Baseline JIT
​https://bugs.webkit.org/show_bug.cgi?id=239708

Reviewed by Yusuke Suzuki.

.:

Turn on the CMake defaults for ENABLE(JIT) and ENABLE(FTL_JIT) options
for RISCV64. These are enabled together to avoid having to worry about
a 64-bit platform that would want to allow compiling with Baseline JIT
enabled and FTL JIT disabled at the same time. But because FTL JIT
support for RISCV64 isn't complete yet, it's still disabled at runtime.

• Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

• runtime/Options.cpp:

(JSC::Options::recomputeDependentOptions):
Disable FTL JIT at runtime under CPU(RISCV64) since the support is still
incomplete. This is necessary due to Baseline JIT and FTL JIT still
being enabled at build-time on this platform for pure convenience.

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/Options.cpp (modified) (1 diff)
• Source/cmake/WebKitFeatures.cmake (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2022-04-24  Zan Dobersek  <zdobersek@igalia.com>
+
+        [RISCV64] Enable Baseline JIT
+        https://bugs.webkit.org/show_bug.cgi?id=239708
+
+        Reviewed by Yusuke Suzuki.
+
+        Turn on the CMake defaults for ENABLE(JIT) and ENABLE(FTL_JIT) options
+        for RISCV64. These are enabled together to avoid having to worry about
+        a 64-bit platform that would want to allow compiling with Baseline JIT
+        enabled and FTL JIT disabled at the same time. But because FTL JIT
+        support for RISCV64 isn't complete yet, it's still disabled at runtime.
+
+        * Source/cmake/WebKitFeatures.cmake:
+
 2022-04-22  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2022-04-24  Zan Dobersek  <zdobersek@igalia.com>
+
+        [RISCV64] Enable Baseline JIT
+        https://bugs.webkit.org/show_bug.cgi?id=239708
+
+        Reviewed by Yusuke Suzuki.
+
+        * runtime/Options.cpp:
+        (JSC::Options::recomputeDependentOptions):
+        Disable FTL JIT at runtime under CPU(RISCV64) since the support is still
+        incomplete. This is necessary due to Baseline JIT and FTL JIT still
+        being enabled at build-time on this platform for pure convenience.
+
 2022-04-24  Diego Pino Garcia  <dpino@igalia.com>
 

trunk/Source/JavaScriptCore/runtime/Options.cpp

@@ -427 +427 @@
 #endif
 #if !ENABLE(FTL_JIT)
+    Options::useFTLJIT() = false;
+#endif
+
+#if CPU(RISCV64)
+    // On RISCV64, JIT levels are enabled at build-time to simplify building JSC, avoiding
+    // otherwise rare combinations of build-time configuration. FTL on RISCV64 is disabled
+    // at runtime for now, until it gets int a proper working state.
+    // https://webkit.org/b/239707
     Options::useFTLJIT() = false;
 #endif

trunk/Source/cmake/WebKitFeatures.cmake

@@ -82 +82 @@
         set(ENABLE_SAMPLING_PROFILER_DEFAULT OFF)
     elseif (WTF_CPU_RISCV64)
-        set(ENABLE_JIT_DEFAULT OFF)
-        set(ENABLE_FTL_DEFAULT OFF)
+        set(ENABLE_JIT_DEFAULT ON)
+        set(ENABLE_FTL_DEFAULT ON)
         set(USE_SYSTEM_MALLOC_DEFAULT OFF)
         set(ENABLE_C_LOOP_DEFAULT OFF)