Changeset 293728 in webkit

Timestamp:

May 3, 2022, 9:09:40 AM (4 years ago)

Author:

youenn@apple.com

Message:

Fix buggy assert in CoreAudioSharedUnit::configureSpeakerProc
​https://bugs.webkit.org/show_bug.cgi?id=240001

Reviewed by Eric Carlson.

Manually tested.

• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

Initialize the sampleRate field before using it.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mediastream/mac/CoreAudioCaptureSource.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-05-03  Youenn Fablet  <youenn@apple.com>
+
+        Fix buggy assert in CoreAudioSharedUnit::configureSpeakerProc
+        https://bugs.webkit.org/show_bug.cgi?id=240001
+
+        Reviewed by Eric Carlson.
+
+        Manually tested.
+
+        * platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+        Initialize the sampleRate field before using it.
+
 2022-05-03  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp

@@ -347 +347 @@
         Locker locker { m_speakerSamplesProducerLock };
         if (m_speakerSamplesProducer) {
+            speakerProcFormat = m_speakerSamplesProducer->format().streamDescription();
             ASSERT(speakerProcFormat.mSampleRate == sampleRate);
-            speakerProcFormat = m_speakerSamplesProducer->format().streamDescription();
         } else {
             err = PAL::AudioUnitGetProperty(m_ioUnit, kAudioUnitProperty_StreamFormat, kAudioUnitScope_Input, outputBus, &speakerProcFormat, &size);