Changeset 293734 in webkit

Timestamp:

May 3, 2022, 11:47:57 AM (4 years ago)

Author:

pvollan@apple.com

Message:

[iOS][WP] Only block IOKit access if all GPUP features are enabled
​https://bugs.webkit.org/show_bug.cgi?id=240010

Reviewed by Tim Horton.

Only block IOKit access in the WebContent process' sandbox on iOS if all GPUP features are enabled.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_appHighlightsVisible):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-05-03  Per Arne Vollan  <pvollan@apple.com>
+
+        [iOS][WP] Only block IOKit access if all GPUP features are enabled
+        https://bugs.webkit.org/show_bug.cgi?id=240010
+
+        Reviewed by Tim Horton.
+
+        Only block IOKit access in the WebContent process' sandbox on iOS if all GPUP features are enabled.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::m_appHighlightsVisible):
+
 2022-05-03  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp

@@ -920 +920 @@
         CFPreferencesGetAppIntegerValue(CFSTR("key"), CFSTR("com.apple.WebKit.WebContent.AppCacheDisabled"), nullptr);
     }
-    if (parameters.store.getBoolValueForKey(WebPreferencesKey::blockIOKitInWebContentSandboxKey()))
+
+    auto blockIOKit = parameters.store.getBoolValueForKey(WebPreferencesKey::blockIOKitInWebContentSandboxKey())
+#if ENABLE(WEBGL)
+        && m_shouldRenderWebGLInGPUProcess
+#endif
+        && m_shouldRenderCanvasInGPUProcess
+        && m_shouldRenderDOMInGPUProcess
+        && m_shouldPlayMediaInGPUProcess;
+
+    if (blockIOKit)
         CFPreferencesGetAppIntegerValue(CFSTR("key"), CFSTR("com.apple.WebKit.WebContent.BlockIOKitInWebContentSandbox"), nullptr);
 #endif