Changeset 293735 in webkit

Timestamp:

May 3, 2022, 12:15:26 PM (4 years ago)

Author:

Chris Dumez

Message:

REGRESSION (r293703): 358 JSC tests failing
​https://bugs.webkit.org/show_bug.cgi?id=240023

Reviewed by Yusuke Suzuki.

Make sure WTF::initialize() calls AtomString::init() given that JSC now relies on
emptyAtom().

• Tools/TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::TestsController::TestsController):

• Source/WTF/wtf/Threading.cpp:

(WTF::initialize):

• Source/WTF/wtf/text/AtomString.cpp:

(WTF::AtomString::init):

• Source/WebCore/platform/CommonAtomStrings.cpp:

(WebCore::initializeCommonAtomStrings):

Canonical link: ​https://commits.webkit.org/250223@main

Location:

trunk

Files:

• Source/WTF/ChangeLog (modified) (1 diff)
• Source/WTF/wtf/Threading.cpp (modified) (2 diffs)
• Source/WTF/wtf/text/AtomString.cpp (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/CommonAtomStrings.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/TestsController.cpp (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2022-05-03  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION (r293703): 358 JSC tests failing
+        https://bugs.webkit.org/show_bug.cgi?id=240023
+        <rdar://problem/92676663>
+
+        Reviewed by Yusuke Suzuki.
+
+        Make sure WTF::initialize() calls AtomString::init() given that JSC now relies on
+        emptyAtom().
+
+        * wtf/Threading.cpp:
+        (WTF::initialize):
+        * wtf/text/AtomString.cpp:
+        (WTF::AtomString::init):
+
 2022-05-03  Philippe Normand  <pnormand@igalia.com> and Pavel Feldman <pavel.feldman@gmail.com> and Yury Semikhatsky <yurys@chromium.org>
 

trunk/Source/WTF/wtf/Threading.cpp

@@ -35 +35 @@
 #include <wtf/ThreadingPrimitives.h>
 #include <wtf/WTFConfig.h>
+#include <wtf/text/AtomString.h>
 #include <wtf/threads/Signals.h>
 
@@ -475 +476 @@
         SignalHandlers::initialize();
 #endif
+        AtomString::init();
     });
 }

trunk/Source/WTF/wtf/text/AtomString.cpp

@@ -142 +142 @@
     static std::once_flag initializeKey;
     std::call_once(initializeKey, [] {
-        // Initialization is not thread safe, so this function must be called from the main thread first.
-        ASSERT(isUIThread());
-
         nullAtomData.construct();
         emptyAtomData.construct(AtomString::fromLatin1(""));

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-05-03  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION (r293703): 358 JSC tests failing
+        https://bugs.webkit.org/show_bug.cgi?id=240023
+        <rdar://problem/92676663>
+
+        Reviewed by Yusuke Suzuki.
+
+        Make sure WTF::initialize() calls AtomString::init() given that JSC now relies on
+        emptyAtom().
+
+        (WebCore::initializeCommonAtomStrings):
+        * platform/CommonAtomStrings.cpp:
+        (WebCore::initializeCommonAtomStrings):
+
 2022-05-03  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/platform/CommonAtomStrings.cpp

@@ -43 +43 @@
     static std::once_flag initializeKey;
     std::call_once(initializeKey, [] {
-        AtomString::init();
-
         WEBCORE_COMMON_ATOM_STRINGS_FOR_EACH_KEYWORD(INITIALIZE_COMMON_ATOM)
     });

trunk/Tools/ChangeLog

@@ +1 @@
+2022-05-03  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION (r293703): 358 JSC tests failing
+        https://bugs.webkit.org/show_bug.cgi?id=240023
+        <rdar://problem/92676663>
+
+        Reviewed by Yusuke Suzuki.
+
+        Make sure WTF::initialize() calls AtomString::init() given that JSC now relies on
+        emptyAtom().
+
+        * TestWebKitAPI/TestsController.cpp:
+        (TestWebKitAPI::TestsController::TestsController):
+
 2022-05-03  Philippe Normand  <pnormand@igalia.com> and Yury Semikhatsky <yurys@chromium.org>
 

trunk/Tools/TestWebKitAPI/TestsController.cpp

@@ -77 +77 @@
     WTF::initializeMainThread();
     WTF::setProcessPrivileges(allPrivileges());
-    AtomString::init();
 }