Changeset 293893 in webkit

Timestamp:

May 6, 2022 8:58:40 AM (2 years ago)

Author:

pvollan@apple.com

Message:

Create reports for long process launch times
​https://bugs.webkit.org/show_bug.cgi?id=240127

Reviewed by Yusuke Suzuki.

We have reports that it can take a long time to launch WebKit processes in some cases. This is the time
it takes from the XPC message is sent until the XPC reply is received. Add reporting when this happens
in order to help diagnose the issue.

• UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::connect):
(WebKit::AuxiliaryProcessProxy::didFinishLaunching):

• UIProcess/AuxiliaryProcessProxy.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/AuxiliaryProcessProxy.cpp (modified) (2 diffs)
• UIProcess/AuxiliaryProcessProxy.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-05-06  Per Arne Vollan  <pvollan@apple.com>
+
+        Create reports for long process launch times
+        https://bugs.webkit.org/show_bug.cgi?id=240127
+
+        Reviewed by Yusuke Suzuki.
+
+        We have reports that it can take a long time to launch WebKit processes in some cases. This is the time 
+        it takes from the XPC message is sent until the XPC reply is received. Add reporting when this happens 
+        in order to help diagnose the issue.
+        
+        * UIProcess/AuxiliaryProcessProxy.cpp:
+        (WebKit::AuxiliaryProcessProxy::connect):
+        (WebKit::AuxiliaryProcessProxy::didFinishLaunching):
+        * UIProcess/AuxiliaryProcessProxy.h:
+
 2022-05-06  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp

@@ -109 +109 @@
 {
     ASSERT(!m_processLauncher);
+    m_proccessStart = MonotonicTime::now();
     ProcessLauncher::LaunchOptions launchOptions;
     getLaunchOptions(launchOptions);
@@ -258 +259 @@
     ASSERT(isMainRunLoop());
 
+    auto launchTime = MonotonicTime::now() - m_proccessStart;
+    if (launchTime > 1_s)
+        RELEASE_LOG_FAULT(Process, "%s process (%p) took %f seconds to launch", processName().characters(), this, launchTime.value());
+    
     if (!IPC::Connection::identifierIsValid(connectionIdentifier))
         return;

trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.h

@@ -188 +188 @@
     WebCore::ProcessIdentifier m_processIdentifier { WebCore::ProcessIdentifier::generate() };
     std::optional<UseLazyStop> m_delayedResponsivenessCheck;
+    MonotonicTime m_proccessStart;
 };