Changeset 294220 in webkit


Ignore:
Timestamp:
May 15, 2022 7:32:13 PM (2 years ago)
Author:
ysuzuki@apple.com
Message:

Unreviewed, revert r294214 partially
​https://bugs.webkit.org/show_bug.cgi?id=240292

These part is not cold code. We must not use PAS_ASSERT_WITH_DETAIL.

  • libpas/src/libpas/pas_local_allocator_config_kind.h:

(pas_local_allocator_config_kind_create_normal):
(pas_local_allocator_config_kind_create_primordial_partial):
(pas_local_allocator_config_kind_create_bitfit):
(pas_local_allocator_config_kind_get_segregated_page_config_kind):
(pas_local_allocator_config_kind_get_bitfit_page_config_kind):
(pas_local_allocator_config_kind_get_string):

Location:
trunk/Source/bmalloc
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/bmalloc/ChangeLog

    r294214 r294220  
     12022-05-15  Yusuke Suzuki  <ysuzuki@apple.com>
     2
     3        Unreviewed, revert r294214 partially
     4        https://bugs.webkit.org/show_bug.cgi?id=240292
     5
     6        These part is not cold code. We must not use PAS_ASSERT_WITH_DETAIL.
     7
     8        * libpas/src/libpas/pas_local_allocator_config_kind.h:
     9        (pas_local_allocator_config_kind_create_normal):
     10        (pas_local_allocator_config_kind_create_primordial_partial):
     11        (pas_local_allocator_config_kind_create_bitfit):
     12        (pas_local_allocator_config_kind_get_segregated_page_config_kind):
     13        (pas_local_allocator_config_kind_get_bitfit_page_config_kind):
     14        (pas_local_allocator_config_kind_get_string):
     15
    1162022-05-14  Justin Michaud  <justin_michaud@apple.com>
    217

  • trunk/Source/bmalloc/libpas/src/libpas/pas_local_allocator_config_kind.h

    r294214 r294220  
    8787#undef PAS_DEFINE_SEGREGATED_PAGE_CONFIG_KIND
    8888    }
    89     PAS_ASSERT_WITH_EXTRA_DETAIL(!"Should not be reached", kind);
     89    PAS_ASSERT(!"Should not be reached");
    9090    return (pas_local_allocator_config_kind)0;
    9191}
    … …  
    101101#undef PAS_DEFINE_SEGREGATED_PAGE_CONFIG_KIND
    102102    }
    103     PAS_ASSERT_WITH_EXTRA_DETAIL(!"Should not be reached", kind);
     103    PAS_ASSERT(!"Should not be reached");
    104104    return (pas_local_allocator_config_kind)0;
    105105}
    … …  
    115115#undef PAS_DEFINE_BITFIT_PAGE_CONFIG_KIND
    116116    }
    117     PAS_ASSERT_WITH_EXTRA_DETAIL(!"Should not be reached", kind);
     117    PAS_ASSERT(!"Should not be reached");
    118118    return (pas_local_allocator_config_kind)0;
    119119}
    … …  
    130130#undef PAS_DEFINE_SEGREGATED_PAGE_CONFIG_KIND
    131131    default:
    132         PAS_ASSERT_WITH_EXTRA_DETAIL(!"Should not be reached", kind);
     132        PAS_ASSERT(!"Should not be reached");
    133133        return (pas_segregated_page_config_kind)0;
    134134    }
    … …  
    145145#undef PAS_DEFINE_BITFIT_PAGE_CONFIG_KIND
    146146    default:
    147         PAS_ASSERT_WITH_EXTRA_DETAIL(!"Should not be reached", kind);
     147        PAS_ASSERT(!"Should not be reached");
    148148        return (pas_bitfit_page_config_kind)0;
    149149    }
    … …  
    171171#undef PAS_DEFINE_BITFIT_PAGE_CONFIG_KIND
    172172    }
    173     PAS_ASSERT_WITH_EXTRA_DETAIL(!"Should not be reached", kind);
     173    PAS_ASSERT(!"Should not be reached");
    174174    return NULL;
    175175}
Note: See TracChangeset for help on using the changeset viewer.