Changeset 294357 in webkit

Timestamp:

May 17, 2022, 4:17:45 PM (4 years ago)

Author:

Adrian Perez de Castro

Message:

Fix Tools/Scripts/check-for-invalid-symbols-in-version-script
​https://bugs.webkit.org/show_bug.cgi?id=240543

Unreviewed build fix.

• Tools/Scripts/check-for-invalid-symbols-in-version-script: Change

shebang to use "python3", and pass an "encoding" argument to the Popen
constructor to read strings instead of bytes from the subprocess pipe.

Location:

releases/WebKitGTK/webkit-2.36/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/check-for-invalid-symbols-in-version-script (modified) (2 diffs)

releases/WebKitGTK/webkit-2.36/Tools/ChangeLog

@@ +1 @@
+2022-05-17  Adrian Perez de Castro  <aperez@igalia.com>
+
+        Fix Tools/Scripts/check-for-invalid-symbols-in-version-script
+        https://bugs.webkit.org/show_bug.cgi?id=240543
+
+        Unreviewed build fix.
+
+        * Tools/Scripts/check-for-invalid-symbols-in-version-script: Change
+        shebang to use "python3", and pass an "encoding" argument to the Popen
+        constructor to read strings instead of bytes from the subprocess pipe.
+
 2022-03-03  Lauro Moura  <lmoura@igalia.com>
 

releases/WebKitGTK/webkit-2.36/Tools/Scripts/check-for-invalid-symbols-in-version-script

@@ -1 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 
 import subprocess
@@ -26 +26 @@
 
 symbols = script_symbols(sys.argv[1])
-p = subprocess.Popen(['objdump', '-t', '-C', sys.argv[2]], stdout=subprocess.PIPE)
+p = subprocess.Popen(['objdump', '-t', '-C', sys.argv[2]], stdout=subprocess.PIPE, encoding="ascii")
 data = p.communicate()[0]