Changeset 294358 in webkit

Timestamp:

May 17, 2022, 4:17:48 PM (4 years ago)

Author:

Adrian Perez de Castro

Message:

[Python3] Fix Tools/Scripts/check-for-invalid-symbols-in-version-script
​https://bugs.webkit.org/show_bug.cgi?id=240543

Reviewed by Michael Catanzaro.

• Tools/Scripts/check-for-invalid-symbols-in-version-script: Change shebang to use "python3", and pass an "encoding" argument to the Popen constructor to read strings instead of bytes from the subprocess pipe.

Canonical link: ​https://commits.webkit.org/250663@main

File:

• trunk/Tools/Scripts/check-for-invalid-symbols-in-version-script (modified) (2 diffs)

trunk/Tools/Scripts/check-for-invalid-symbols-in-version-script

@@ -1 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 
 import subprocess
@@ -26 +26 @@
 
 symbols = script_symbols(sys.argv[1])
-p = subprocess.Popen(['objdump', '-t', '-C', sys.argv[2]], stdout=subprocess.PIPE)
+p = subprocess.Popen(['objdump', '-t', '-C', sys.argv[2]], stdout=subprocess.PIPE, encoding="ascii")
 data = p.communicate()[0]