Changeset 294389 in webkit

Timestamp:

May 18, 2022, 4:23:11 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

ENABLE_LAYER_BASED_SVG_ENGINE needs to match for iOS and macOS
​https://bugs.webkit.org/show_bug.cgi?id=239877
<rdar://problem/92829309>

Patch by Nikolas Zimmermann <​nzimmermann@igalia.com> on 2022-05-18
Reviewed by Simon Fraser.

Switch on ENABLE_LAYER_BASED_SVG_ENGINE for all Cocoa based platforms.

This only works after fixing one build issue:
hasTransform() now needs hasSVGTransform(), when in turn uses rareData(), which
is not exported by WebCore at present breaking tvOS/watchOS/iOS builds, fix that.

Covered by existing tests, no change in behaviour.

• Source/WTF/wtf/PlatformEnableCocoa.h:
• Source/WebCore/rendering/RenderObject.h:

Location:

trunk/Source

Files:

• WTF/wtf/PlatformEnableCocoa.h (modified) (1 diff)
• WebCore/rendering/RenderObject.h (modified) (1 diff)

trunk/Source/WTF/wtf/PlatformEnableCocoa.h

@@ -341 +341 @@
 #endif
 
-#if !defined(ENABLE_LAYER_BASED_SVG_ENGINE) && PLATFORM(MAC)
+#if !defined(ENABLE_LAYER_BASED_SVG_ENGINE)
 #define ENABLE_LAYER_BASED_SVG_ENGINE 1
 #endif

trunk/Source/WebCore/rendering/RenderObject.h

@@ -976 +976 @@
     };
     
-    const RenderObject::RenderObjectRareData& rareData() const;
+    WEBCORE_EXPORT const RenderObject::RenderObjectRareData& rareData() const;
     RenderObjectRareData& ensureRareData();
     void removeRareData();