Changeset 294392 in webkit

Timestamp:

May 18, 2022, 5:59:08 AM (4 years ago)

Author:

graouts@webkit.org

Message:

[web-animations] ensure that animations using offset properties correctly run on a composited layer
​https://bugs.webkit.org/show_bug.cgi?id=236709
<rdar://problem/89029756>

Reviewed by Dean Jackson.

Add all the CSS properties related to the CSS Motion Path feature to
RenderLayerCompositor::requiresCompositingForAnimation() in order to
ensure that an element's renderer is composited when one of those
properties is animated.

Tests: webanimations/offset-anchor-animation-yields-compositing.html

webanimations/offset-distance-animation-yields-compositing.html
webanimations/offset-path-animation-yields-compositing.html
webanimations/offset-position-animation-yields-compositing.html
webanimations/offset-rotate-animation-yields-compositing.html
webanimations/offset-shorthand-animation-yields-compositing.html

• Source/WebCore/rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const):

• LayoutTests/webanimations/offset-anchor-animation-yields-compositing-expected.txt: Added.
• LayoutTests/webanimations/offset-anchor-animation-yields-compositing.html: Added.
• LayoutTests/webanimations/offset-distance-animation-yields-compositing-expected.txt: Added.
• LayoutTests/webanimations/offset-distance-animation-yields-compositing.html: Added.
• LayoutTests/webanimations/offset-path-animation-yields-compositing-expected.txt: Added.
• LayoutTests/webanimations/offset-path-animation-yields-compositing.html: Added.
• LayoutTests/webanimations/offset-position-animation-yields-compositing-expected.txt: Added.
• LayoutTests/webanimations/offset-position-animation-yields-compositing.html: Added.
• LayoutTests/webanimations/offset-rotate-animation-yields-compositing-expected.txt: Added.
• LayoutTests/webanimations/offset-rotate-animation-yields-compositing.html: Added.
• LayoutTests/webanimations/offset-shorthand-animation-yields-compositing-expected.txt: Added.
• LayoutTests/webanimations/offset-shorthand-animation-yields-compositing.html: Added.

Canonical link: ​https://commits.webkit.org/250687@main

Location:

trunk

Files:

• LayoutTests/webanimations/offset-anchor-animation-yields-compositing-expected.txt (added)
• LayoutTests/webanimations/offset-anchor-animation-yields-compositing.html (added)
• LayoutTests/webanimations/offset-distance-animation-yields-compositing-expected.txt (added)
• LayoutTests/webanimations/offset-distance-animation-yields-compositing.html (added)
• LayoutTests/webanimations/offset-path-animation-yields-compositing-expected.txt (added)
• LayoutTests/webanimations/offset-path-animation-yields-compositing.html (added)
• LayoutTests/webanimations/offset-position-animation-yields-compositing-expected.txt (added)
• LayoutTests/webanimations/offset-position-animation-yields-compositing.html (added)
• LayoutTests/webanimations/offset-rotate-animation-yields-compositing-expected.txt (added)
• LayoutTests/webanimations/offset-rotate-animation-yields-compositing.html (added)
• LayoutTests/webanimations/offset-shorthand-animation-yields-compositing-expected.txt (added)
• LayoutTests/webanimations/offset-shorthand-animation-yields-compositing.html (added)
• Source/WebCore/rendering/RenderLayerCompositor.cpp (modified) (1 diff)

trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

@@ -3008 +3008 @@
                 || effectsStack->isCurrentlyAffectingProperty(CSSPropertyScale)
                 || effectsStack->isCurrentlyAffectingProperty(CSSPropertyRotate)
-                || effectsStack->isCurrentlyAffectingProperty(CSSPropertyTransform);
+                || effectsStack->isCurrentlyAffectingProperty(CSSPropertyTransform)
+                || effectsStack->isCurrentlyAffectingProperty(CSSPropertyOffsetAnchor)
+                || effectsStack->isCurrentlyAffectingProperty(CSSPropertyOffsetDistance)
+                || effectsStack->isCurrentlyAffectingProperty(CSSPropertyOffsetPath)
+                || effectsStack->isCurrentlyAffectingProperty(CSSPropertyOffsetPosition)
+                || effectsStack->isCurrentlyAffectingProperty(CSSPropertyOffsetRotate);
         }
     }