Changeset 294618 in webkit

Timestamp:

May 21, 2022 7:34:32 PM (2 years ago)

Author:

Alan Bujtas

Message:

Invisible border should not trigger Repaint diff when currentColor changes
​https://bugs.webkit.org/show_bug.cgi?id=240763

Reviewed by Simon Fraser.

Let's check if the border is visible to decide if the currentColor should trigger Repaint diff.

Test: fast/repaint/currentColorChange-with-non-visible-border.html

• Source/WebCore/rendering/style/BorderData.cpp:

(WebCore::BorderData::isEquivalentForPainting const):

• LayoutTests/fast/repaint/currentColorChange-with-non-visible-border-expected.txt: Added.
• LayoutTests/fast/repaint/currentColorChange-with-non-visible-border.html: Added.

Canonical link: ​https://commits.webkit.org/250844@main

Location:

trunk

Files:

• LayoutTests/fast/repaint/currentColorChange-with-non-visible-border-expected.txt (added)
• LayoutTests/fast/repaint/currentColorChange-with-non-visible-border.html (added)
• Source/WebCore/rendering/style/BorderData.cpp (modified) (1 diff)

trunk/Source/WebCore/rendering/style/BorderData.cpp

@@ -41 +41 @@
         return true;
 
-    auto borderHasCurrentColor = RenderStyle::isCurrentColor(m_top.color()) || RenderStyle::isCurrentColor(m_right.color()) || RenderStyle::isCurrentColor(m_bottom.color()) || RenderStyle::isCurrentColor(m_left.color());
-    return !borderHasCurrentColor;
+    auto visibleBorderHasCurrentColor = (m_top.isVisible() && RenderStyle::isCurrentColor(m_top.color()))
+        || (m_right.isVisible() && RenderStyle::isCurrentColor(m_right.color()))
+        || (m_bottom.isVisible() && RenderStyle::isCurrentColor(m_bottom.color()))
+        || (m_left.isVisible() && RenderStyle::isCurrentColor(m_left.color()));
+    return !visibleBorderHasCurrentColor;
 }