Changeset 294620 in webkit

Timestamp:

May 22, 2022 7:36:15 AM (2 years ago)

Author:

Antti Koivisto

Message:

REGRESSION(r293956): Bad color inheritance due to disallowsFastPathInheritance bit missing from RenderStyle::copyNonInheritedFrom
​https://bugs.webkit.org/show_bug.cgi?id=240770

Reviewed by Alan Bujtas.

Test: fast/css/color-inheritance-dynamic.html

• Source/WebCore/rendering/style/RenderStyle.h:

(WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom):

Add it.

• LayoutTests/fast/css/color-inheritance-dynamic-expected.html: Added.
• LayoutTests/fast/css/color-inheritance-dynamic.html: Added.

Canonical link: ​https://commits.webkit.org/250846@main

Location:

trunk

Files:

• LayoutTests/fast/css/color-inheritance-dynamic-expected.html (added)
• LayoutTests/fast/css/color-inheritance-dynamic.html (added)
• Source/WebCore/rendering/style/RenderStyle.h (modified) (1 diff)

trunk/Source/WebCore/rendering/style/RenderStyle.h

@@ -2168 +2168 @@
     hasViewportUnits = other.hasViewportUnits;
     hasExplicitlyInheritedProperties = other.hasExplicitlyInheritedProperties;
+    disallowsFastPathInheritance = other.disallowsFastPathInheritance;
 
     // Unlike properties tracked by the other hasExplicitlySet* flags, border-radius is non-inherited