Changeset 294716 in webkit

Timestamp:

May 23, 2022, 7:40:27 PM (4 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Network Table: activity is not marked as a previous session when the Network Tab is not selected
​https://bugs.webkit.org/show_bug.cgi?id=240846

Reviewed by Patrick Angle.

• Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype._mainResourceDidChange):
(WI.NetworkTableContentView.prototype._entryForResource):
Also mark WI.Resource that haven't yet been inserted into the WI.Table when navigating the main
resource. Use this when generating an entry for that WI.Resource for the first time, instead of
always assuming that the WI.Resource is part of the current session.

Canonical link: ​https://commits.webkit.org/250902@main

File:

• trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js

@@ -1654 +1654 @@
                     for (let entry of collection.entries)
                         entry.currentSession = false;
+
+                    for (let resource of collection.pendingInsertions)
+                        resource[WI.NetworkTableContentView._currentSessionSymbol] = false;
                 }
             }
@@ -1905 +1908 @@
             connectionIdentifier: resource.connectionIdentifier,
             startTime: resource.firstTimestamp,
-            currentSession: true,
+            currentSession: resource[WI.NetworkTableContentView._currentSessionSymbol] ?? true,
         };
     }
@@ -2534 +2537 @@
     }
 };
+
+WI.NetworkTableContentView._currentSessionSymbol = Symbol("current-session");