Changeset 294759 in webkit

Timestamp:

May 24, 2022, 1:14:02 PM (4 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Timelines Tab: Screenshots: show placeholder text when there's no images
​https://bugs.webkit.org/show_bug.cgi?id=240851

Reviewed by Patrick Angle.

• Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.js:

(WI.ScreenshotsTimelineView.prototype.layout):

• Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:

Canonical link: ​https://commits.webkit.org/250927@main

Location:

trunk/Source/WebInspectorUI

Files:

• Localizations/en.lproj/localizedStrings.js (modified) (1 diff)
• UserInterface/Views/ScreenshotsTimelineView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -1030 +1030 @@
 localizedStrings["No response cookies."] = "No response cookies.";
 localizedStrings["No response headers"] = "No response headers";
+/* Placeholder text shown when there are no images to display in the Screenshots timeline. */
+localizedStrings["No screenshots @ Screenshots Timeline"] = "No screenshots";
 localizedStrings["No search results"] = "No search results";
 localizedStrings["No search string"] = "No search string";

trunk/Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.js

@@ -80 +80 @@
             });
         }        
+
+        if (!this.element.childNodes.length)
+            this.element.appendChild(WI.createMessageTextView(WI.UIString("No screenshots", "No screenshots @ Screenshots Timeline", "Placeholder text shown when there are no images to display in the Screenshots timeline.")));
     }