Changeset 294809 in webkit

Timestamp:

May 25, 2022 11:01:30 AM (2 years ago)

Author:

pvollan@apple.com

Message:

Add logging related to Mach bootstrap enablement
​https://bugs.webkit.org/show_bug.cgi?id=240909

Reviewed by Chris Dumez.

We are seeing telemetry that indicates that enabling Mach bootstrap is failing in some cases.
Add logging to help diagnose this.

• Source/WebKit/Platform/Logging.h:
• Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:

(WebKit::SandboxExtension::createHandleForMachLookup):

• Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:

(WebKit::SandboxExtension::createHandleForMachLookup):

Canonical link: ​https://commits.webkit.org/250963@main

Location:

trunk/Source/WebKit

Files:

• Platform/Logging.h (modified) (1 diff)
• Shared/Cocoa/SandboxExtensionCocoa.mm (modified) (2 diffs)

trunk/Source/WebKit/Platform/Logging.h

@@ -94 +94 @@
     M(Resize) \
     M(ResourceLoadStatistics) \
+    M(Sandbox) \
     M(ScrollAnimations) \
     M(Scrolling) \

trunk/Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm

@@ -33 +33 @@
 #import "Decoder.h"
 #import "Encoder.h"
+#import "Logging.h"
 #import "WebCoreArgumentCoders.h"
 #import <string.h>
@@ -338 +339 @@
     // Unblocking launchd is done by enabling a sandbox state variable.
     // In the initial version of this change, Mach bootstrap'ing is enabled unconditionally.
-    if (auditToken)
-        sandbox_enable_state_flag(ENABLE_MACH_BOOTSTRAP, *auditToken);
+    if (auditToken) {
+        if (!sandbox_enable_state_flag(ENABLE_MACH_BOOTSTRAP, *auditToken))
+            RELEASE_LOG_FAULT(Sandbox, "Could not enable Mach bootstrap, errno = %d.", errno);
+    } else if (machBootstrapOptions == MachBootstrapOptions::EnableMachBootstrap)
+        RELEASE_LOG_FAULT(Sandbox, "Could not enable Mach bootstrap, no audit token provided.");
 #endif