Changeset 294814 in webkit

Timestamp:

May 25, 2022 11:55:19 AM (2 years ago)

Author:

pvollan@apple.com

Message:

[iOS] Remove obsolete graphics message filters
​https://bugs.webkit.org/show_bug.cgi?id=240736
<rdar://93527356>

Reviewed by Geoffrey Garen.

Remove obsolete graphics filters in the WebContent process' sandbox on iOS, since this filtering is
now done in other parts of the system.

• Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

Canonical link: ​https://commits.webkit.org/250967@main

File:

• trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (modified) (4 diffs)

trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in

@@ -221 +221 @@
         (require-all
             (extension "com.apple.webkit.extension.iokit")
-            (iokit-connection "IOGPU")
-        )
-        (when (defined? 'iokit-external-method)
-            (apply-message-filter
-                (deny (with telemetry)
-                    iokit-external-trap)
-                (allow (with telemetry) (with message "IOGPU")
-                    iokit-async-external-method
-                    iokit-external-method)
-            )
-        )
-    )
+            (iokit-connection "IOGPU")))
 
     (allow iokit-open
         (require-all
             (extension "com.apple.webkit.extension.iokit")
-            (iokit-user-client-class "AGXDeviceUserClient") ;; Used by WebGL
-        )
-        (when (defined? 'iokit-external-method)
-            (apply-message-filter
-                (deny (with telemetry)
-                    iokit-external-trap)
-                (deny (with telemetry) (with message "AGXDeviceUserClient")
-                    iokit-async-external-method
-                    iokit-external-method
-                )
-                (allow iokit-async-external-method)
-                (allow iokit-external-method)
-            )
-        )
-    )
+            (iokit-user-client-class "AGXDeviceUserClient"))) ;; Used by WebGL
 
     (allow iokit-get-properties
@@ -366 +341 @@
         (home-subpath "/Library/VoiceServices/Assets")
         (home-subpath "/Library/Assets/com_apple_MobileAsset_VoiceServicesVocalizerVoice"))
-)
-
-(define (IOSurfaceRootUserClientMethodFilter)
-    (when (defined? 'iokit-external-method)
-        (apply-message-filter
-            (deny (with telemetry)
-                iokit-async-external-method
-                iokit-external-trap)
-            (allow iokit-async-external-method)
-            (deny (with telemetry) (with message "IOSurfaceRootUserClient")
-                iokit-external-method)
-            (allow iokit-external-method)
-        )
-    )
 )
 
@@ -430 +391 @@
         (require-all
             (extension "com.apple.webkit.extension.iokit")
-            (iokit-user-client-class "IOSurfaceRootUserClient") ;; Needed by Tiled Grid code.
-        )
-        (IOSurfaceRootUserClientMethodFilter)
-    )
+            (iokit-user-client-class "IOSurfaceRootUserClient"))) ;; Needed by Tiled Grid code.
 
     ;; Silence sandbox violations from apps trying to create the empty plist if it doesn't exist.
@@ -977 +935 @@
     (require-all
         (require-not (extension "com.apple.webkit.extension.iokit"))
-        (iokit-user-client-class
-            "IOSurfaceRootUserClient"
-        )
-    )
-    (IOSurfaceRootUserClientMethodFilter)
-)
+        (iokit-user-client-class "IOSurfaceRootUserClient")))
 
 (deny iokit-open (with telemetry)