Changeset 294841 in webkit

Timestamp:

May 25, 2022, 4:49:44 PM (4 years ago)

Author:

Alan Coon

Message:

Cherry-pick r293827. rdar://problem/92624773

replaceTrack with different constraints stops sending packets
​https://bugs.webkit.org/show_bug.cgi?id=239978
<rdar://problem/92624773>

Reviewed by Eric Carlson.

We should always reconfigure the microphone processor even if we are not using it,
as VPIO expects that input and output formats should match.

Manually tested with ​https://bugs.webkit.org/show_bug.cgi?id=239978 and ​https://jsfiddle.net/72qsLw9a/.
A follow-up should allow to put more common code between CoreAudioSharedUnit and MockAudioSharedUnit
so that we can write a regression test.

• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

Canonical link: ​https://commits.webkit.org/250300@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-613-branch/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mediastream/mac/CoreAudioCaptureSource.cpp (modified) (1 diff)

branches/safari-613-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2022-05-19  Alan Coon  <alancoon@apple.com>
+
+        Cherry-pick r293827. rdar://problem/92624773
+
+    replaceTrack with different constraints stops sending packets
+    https://bugs.webkit.org/show_bug.cgi?id=239978
+    <rdar://problem/92624773>
+    
+    Reviewed by Eric Carlson.
+    
+    We should always reconfigure the microphone processor even if we are not using it,
+    as VPIO expects that input and output formats should match.
+    
+    Manually tested with https://bugs.webkit.org/show_bug.cgi?id=239978 and https://jsfiddle.net/72qsLw9a/.
+    A follow-up should allow to put more common code between CoreAudioSharedUnit and MockAudioSharedUnit
+    so that we can write a regression test.
+    
+    * platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+    
+    Canonical link: https://commits.webkit.org/250300@main
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2022-05-05  Youenn Fablet  <youenn@apple.com>
+
+            replaceTrack with different constraints stops sending packets
+            https://bugs.webkit.org/show_bug.cgi?id=239978
+            <rdar://problem/92624773>
+
+            Reviewed by Eric Carlson.
+
+            We should always reconfigure the microphone processor even if we are not using it,
+            as VPIO expects that input and output formats should match.
+
+            Manually tested with https://bugs.webkit.org/show_bug.cgi?id=239978 and https://jsfiddle.net/72qsLw9a/.
+            A follow-up should allow to put more common code between CoreAudioSharedUnit and MockAudioSharedUnit
+            so that we can write a regression test.
+
+            * platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+
 2022-05-19  Alan Coon  <alancoon@apple.com>
 

branches/safari-613-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp

@@ -299 +299 @@
     ASSERT(isMainThread());
 
-    if (!isProducingMicrophoneSamples())
-        return noErr;
-
     AURenderCallbackStruct callback = { microphoneCallback, this };
     auto err = PAL::AudioUnitSetProperty(m_ioUnit, kAudioOutputUnitProperty_SetInputCallback, kAudioUnitScope_Global, inputBus, &callback, sizeof(callback));