Changeset 294897 in webkit

Timestamp:

May 26, 2022, 2:12:24 PM (4 years ago)

Author:

david_quesada@apple.com

Message:

Define WK_NOT_NO in SDKVariant.xcconfig
​https://bugs.webkit.org/show_bug.cgi?id=240963
rdar://problem/93984643

Reviewed by Alexey Proskuryakov.

Provide a definition of WK_NOT_NO = YES, so that the $(WK_NOT_$(SOME_BUILD_SETTING)) construction can
be relied upon to produce a result of YES if the original build setting has a value of NO, which shouldn't
be handled substantially different from an empty string.

• PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig:
• Source/JavaScriptCore/Configurations/SDKVariant.xcconfig:
• Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig:
• Source/ThirdParty/gtest/xcode/Config/SDKVariant.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/SDKVariant.xcconfig:
• Source/WTF/Configurations/SDKVariant.xcconfig:
• Source/WebCore/Configurations/SDKVariant.xcconfig:
• Source/WebCore/PAL/Configurations/SDKVariant.xcconfig:
• Source/WebGPU/Configurations/SDKVariant.xcconfig:
• Source/WebInspectorUI/Configurations/SDKVariant.xcconfig:
• Source/WebKit/Configurations/SDKVariant.xcconfig:
• Source/WebKitLegacy/mac/Configurations/SDKVariant.xcconfig:
• Source/bmalloc/Configurations/SDKVariant.xcconfig:
• Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig:
• Tools/DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
• Tools/ImageDiff/cg/Configurations/SDKVariant.xcconfig:
• Tools/MiniBrowser/Configurations/SDKVariant.xcconfig:
• Tools/MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
• Tools/TestWebKitAPI/Configurations/SDKVariant.xcconfig:
• Tools/WebEditingTester/Configurations/SDKVariant.xcconfig:
• Tools/WebKitTestRunner/Configurations/SDKVariant.xcconfig:
• Tools/lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:

Canonical link: ​https://commits.webkit.org/251020@main

Location:

trunk

Files:

• PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Source/JavaScriptCore/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Source/ThirdParty/gtest/xcode/Config/SDKVariant.xcconfig (modified) (1 diff)
• Source/ThirdParty/libwebrtc/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Source/WTF/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Source/WebCore/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Source/WebCore/PAL/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Source/WebGPU/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Source/WebInspectorUI/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Source/WebKit/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Source/WebKitLegacy/mac/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Source/bmalloc/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Tools/DumpRenderTree/mac/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Tools/ImageDiff/cg/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Tools/MiniBrowser/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Tools/MobileMiniBrowser/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Tools/TestWebKitAPI/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Tools/WebEditingTester/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Tools/WebKitTestRunner/Configurations/SDKVariant.xcconfig (modified) (1 diff)
• Tools/lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig (modified) (1 diff)

trunk/PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Source/JavaScriptCore/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Source/ThirdParty/gtest/xcode/Config/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Source/ThirdParty/libwebrtc/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Source/WTF/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Source/WebCore/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Source/WebCore/PAL/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Source/WebGPU/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Source/WebInspectorUI/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Source/WebKit/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Source/WebKitLegacy/mac/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Source/bmalloc/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Tools/DumpRenderTree/mac/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Tools/ImageDiff/cg/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Tools/MiniBrowser/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Tools/MobileMiniBrowser/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Tools/TestWebKitAPI/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Tools/WebEditingTester/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Tools/WebKitTestRunner/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;
 

trunk/Tools/lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig

@@ -24 +24 @@
 WK_EMPTY_ = YES;
 WK_NOT_ = YES;
+WK_NOT_NO = YES;
 WK_NOT_YES = NO;