Changeset 295124 in webkit

Timestamp:

Jun 2, 2022 5:52:52 AM (2 years ago)

Author:

Alan Bujtas

Message:

Do not assume that an absolute positioned block box's height is always resolvable
​https://bugs.webkit.org/show_bug.cgi?id=241213

Reviewed by Simon Fraser.

1. While the ICB (RenderView) always has fixed height/width, the RenderStyle values are set to auto.
2. It's incorrect to assume that we can always resolve the height for an absolute positioned box (e.g. it may have a "height: auto" relative positioned containing block)

• LayoutTests/fast/block/fill-available-with-absolute-position-expected.html: Added.
• LayoutTests/fast/block/fill-available-with-absolute-position.html: Added.
• Source/WebCore/rendering/RenderBox.cpp:

(WebCore::RenderBox::computeIntrinsicLogicalContentHeightUsing const):
(WebCore::RenderBox::computePositionedLogicalHeightUsing const):

Canonical link: ​https://commits.webkit.org/251215@main

Location:

trunk

Files:

• LayoutTests/fast/block/fill-available-with-absolute-position-expected.html (added)
• LayoutTests/fast/block/fill-available-with-absolute-position.html (added)
• Source/WebCore/rendering/RenderBox.cpp (modified) (2 diffs)

trunk/Source/WebCore/rendering/RenderBox.cpp

@@ -3282 +3282 @@
             if (!containingBlock)
                 return false;
+            if (is<RenderView>(containingBlock))
+                return true;
             auto containingBlockHasSpecifiedSpace = [&] {
                 auto isOrthogonal = WebCore::isOrthogonal(*this, *containingBlock);
@@ -4479 +4481 @@
     } else {
         if (logicalHeightLength.isIntrinsic())
-            resolvedLogicalHeight = adjustContentBoxLogicalHeightForBoxSizing(computeIntrinsicLogicalContentHeightUsing(logicalHeightLength, contentLogicalHeight, bordersPlusPadding).value());
+            resolvedLogicalHeight = adjustContentBoxLogicalHeightForBoxSizing(computeIntrinsicLogicalContentHeightUsing(logicalHeightLength, contentLogicalHeight, bordersPlusPadding).value_or(0_lu));
         else if (fromAspectRatio) {
             resolvedLogicalHeight = blockSizeFromAspectRatio(horizontalBorderAndPaddingExtent(), verticalBorderAndPaddingExtent(), style().logicalAspectRatio(), style().boxSizingForAspectRatio(), logicalWidth());