Changeset 295164 in webkit

Timestamp:

Jun 2, 2022, 6:04:41 PM (4 years ago)

Author:

Patrick Angle

Message:

Web Inspector: Layout overlay color swatches don't update saved color until popover is dismissed
​https://bugs.webkit.org/show_bug.cgi?id=241244
rdar://94318762

Reviewed by Devin Rousso.

We should save all changes to layout overlay color, not just the state when you close the color picker popover. Not
doing this causes a few issues:

1. DOM node badge colors don't update as you dynamically adjust the color for an overlay.
2. The new "sample color from screen" can be used without opening the popover for the color picker, which means these

changes are never saved.

Canonical link: ​https://commits.webkit.org/251248@main

Location:

trunk/Source/WebInspectorUI/UserInterface

Files:

• Models/DOMNode.js (modified) (1 diff)
• Views/NodeOverlayListSection.js (modified) (1 diff)

trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js

@@ -710 +710 @@
         this._createLayoutOverlayColorSettingIfNeeded();
         this._layoutOverlayColorSetting.value = color.hsl;
+
+        if (this._layoutOverlayShowing)
+            this.showLayoutOverlay({color});
     }
 

trunk/Source/WebInspectorUI/UserInterface/Views/NodeOverlayListSection.js

@@ -126 +126 @@
 
             swatch.addEventListener(WI.InlineSwatch.Event.ValueChanged, (event) => {
-                if (checkboxElement?.checked)
-                    domNode.showLayoutOverlay({color: event.data.value});
-            }, swatch);
-
-            swatch.addEventListener(WI.InlineSwatch.Event.Deactivated, (event) => {
                 domNode.layoutOverlayColor = event.target.value;
             }, swatch);