Changeset 295170 in webkit

Timestamp:

Jun 2, 2022, 10:35:30 PM (4 years ago)

Author:

Nikos Mouchtaris

Message:

Add check for pixel buffer format in RemoteRenderingBackend::getPixelBufferForImageBuffer
​https://bugs.webkit.org/show_bug.cgi?id=241243
<rdar://89611041>

Reviewed by Simon Fraser.

Add check to ensure that pixel buffer format is supported.

• Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::getPixelBufferForImageBuffer):

Canonical link: ​https://commits.webkit.org/251254@main

Location:

trunk/Source

Files:

• WebCore/platform/graphics/PixelBuffer.h (modified) (1 diff)
• WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp (modified) (1 diff)

trunk/Source/WebCore/platform/graphics/PixelBuffer.h

@@ -40 +40 @@
     WTF_MAKE_NONCOPYABLE(PixelBuffer);
 public:
-    static bool supportedPixelFormat(PixelFormat);
+    WEBCORE_EXPORT static bool supportedPixelFormat(PixelFormat);
 
     WEBCORE_EXPORT static RefPtr<PixelBuffer> tryCreate(const PixelBufferFormat&, const IntSize&);

trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp

@@ -208 +208 @@
 {
     MESSAGE_CHECK(m_getPixelBufferSharedMemory, "No shared memory for getPixelBufferForImageBuffer");
+    MESSAGE_CHECK(PixelBuffer::supportedPixelFormat(destinationFormat.pixelFormat), "Pixel format not supported");
     QualifiedRenderingResourceIdentifier qualifiedImageBuffer { imageBuffer, m_gpuConnectionToWebProcess->webProcessIdentifier() };
     if (auto imageBuffer = m_remoteResourceCache.cachedImageBuffer(qualifiedImageBuffer)) {